mgr/prometheus: fix metrics service not coming up#64385
Conversation
a065553 to
0f2dbbd
Compare
|
@adk3798 @rkachach added a basic test in the suite to catch the issues: https://github.com/ceph/ceph/pull/64385/files#diff-2917dc4cd5328997a38bfe2819085b8b85b430e3972e817fd26ca2662be0ee27 |
|
@nizamial09 can you see if these two issues are related to this fix? https://tracker.ceph.com/issues/72012 If so, can you add the PR to the tickets? |
yup, they are related. I added the PR into those trackers. thanks @ljflores |
|
jenkins test make check |
Thanks @nizamial09. I marked one of the tickets as a duplicate, so we can use this one to track the fix: https://tracker.ceph.com/issues/72012 Can you add it to the commit description? |
ceph#61468 unintentionally broke the http metric service while it removed the code that starts the metrics. adding them back up. adding a basic test to catch these issues Regression from ceph@64f590c#diff-031e09c4297d84a407cf55f8981d38764efc3c37e9827e12e638521f69284e1f Fixes: https://tracker.ceph.com/issues/72012 Signed-off-by: Nizamudeen A <nia@redhat.com>
0f2dbbd to
6a37fc8
Compare
yup, thanks again. added it. |
|
jenkins test api |
1 similar comment
|
jenkins test api |
|
@adk3798 can you help prioritize this, this PR is blocking lot of other work to be tested. |
|
@nizamial09 Shouldn't this be backported to tentacle? |
|
@avanthakkar tentacle is not broken...yet. there are PRs open to backport the original PR that broke it. And this commit is included in it |
#61468 unintentionally broke the http metric service while it removed the code that starts the metrics. adding them back up.
Regression from 64f590c#diff-031e09c4297d84a407cf55f8981d38764efc3c37e9827e12e638521f69284e1f
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition