Conversation
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
d6f4c22 to
5f08725
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
5f08725 to
f00b24c
Compare
e9d6f50 to
0fed13b
Compare
837c856 to
b719182
Compare
|
jenkins test make check |
|
jenkins test windows |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
b719182 to
df7bce4
Compare
|
jenkins test make check |
Use the new tls credential resource and remote control cluster field to configure the tls creds for the remote control sidecar in the service spec. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Update the handler code needed to make tls credential types work corrently for `ceph smb show` commands. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Support populating the cert data sent to the cephadm binary using special `URI:` prefixed strings instead of putting the cert data itself in the smb service spec. This avoids having an extra copy of the cert floating around but still matches the behavior of other services where cephadm writes the certs into files. In the future we may be able to avoid even putting the data in here as sambacc can use rados apis - but for simplicity and matching other services we will send the data this way for now. Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
3603a87 to
17eeb7b
Compare
anoopcs9
left a comment
There was a problem hiding this comment.
Looks OK at a very high level.
17eeb7b to
a49bfdc
Compare
It covers the remote control configuration object and the tls credential resource and source object created to support it and future tls needs. Signed-off-by: John Mulligan <jmulligan@redhat.com>
When not referring to a code object or field value or module name, try to spell ID and SMB in all caps everywhere in the document. Signed-off-by: John Mulligan <jmulligan@redhat.com>
a49bfdc to
3e7009d
Compare
|
jenkins test make check |
2 similar comments
|
jenkins test make check |
|
jenkins test make check |
|
jenkins test dashboard cephadm |
|
jenkins test make check |
1 similar comment
|
jenkins test make check |
|
jenkins test dashboard cephadm |
|
jenkins test make check |
|
jenkins test dashboard cephadm |
2 similar comments
|
jenkins test dashboard cephadm |
|
jenkins test dashboard cephadm |
|
@adk3798 Given that ceph dashboard cephadm e2e tests is not listed as |
|
jenkins test dashboard cephadm |
Depends on #64142
Add support for an optional remote-control sidecar server. This server is provided by the sambacc project and creates a gRPC interface that allows systems outside the ceph cluster to get realtime-ish connection information and make changes like disconnecting a client or share.
This server uses mTLS for simple auth{n,z} if a server cert, server key and ca cert are provided. The server can also be deployed in an insecure mode (no TLS) and or non-authenticating mode (no CA Cert). However, these modes are read-only and are mainly just for testing.
To support TLS credentials, a new top-level resource type
ceph.smb.tls.credentialis added. This type is somewhat similar to the theceph.smb.join.authtype in behavior. See the updated doc for more information.Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition