Skip to content

rgw: Fix the version of restore_pool and dedup_pool#64361

Merged
cbodley merged 1 commit intoceph:mainfrom
soumyakoduri:wip-skoduri-zoneparams-vers
Jul 10, 2025
Merged

rgw: Fix the version of restore_pool and dedup_pool#64361
cbodley merged 1 commit intoceph:mainfrom
soumyakoduri:wip-skoduri-zoneparams-vers

Conversation

@soumyakoduri
Copy link
Contributor

@soumyakoduri soumyakoduri commented Jul 7, 2025

struct RGWZoneParams variable restore_pool was added with v16 in an earlier release. So to be compatible with those releases, retain that version for restore_pool and update version of dedup_pool to v17.

Fixes: https://tracker.ceph.com/issues/70628
Signed-off-by: Soumya Koduri skoduri@redhat.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@soumyakoduri soumyakoduri requested a review from a team as a code owner July 7, 2025 07:26
@soumyakoduri soumyakoduri requested review from benhanokh and removed request for a team July 7, 2025 07:26
@github-actions github-actions bot added the rgw label Jul 7, 2025
} else {
restore_pool = log_pool.name + ":restore";
}
if (struct_v >= 17) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump ENCODE_START(16 and DECODE_START(16 to 17

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbodley .. I now rebased this change on top of #62713 (which bumped up the ENCODE_START and DECODE_START version to 17)

@soumyakoduri soumyakoduri force-pushed the wip-skoduri-zoneparams-vers branch 2 times, most recently from 9fed38d to 6cf1f4c Compare July 7, 2025 15:41
@soumyakoduri
Copy link
Contributor Author

jenkins test windows

Fix the version of `restore_pool` and `dedup_pool` to be
 compatible with earlier releases.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
@soumyakoduri soumyakoduri force-pushed the wip-skoduri-zoneparams-vers branch from 6cf1f4c to b6fc0be Compare July 8, 2025 18:44
@soumyakoduri
Copy link
Contributor Author

@soumyakoduri
Copy link
Contributor Author

jenkins test make check arm64

@soumyakoduri
Copy link
Contributor Author

jenkins test windows

@soumyakoduri
Copy link
Contributor Author

jenkins test api

@soumyakoduri
Copy link
Contributor Author

jenkins test make check arm64

@soumyakoduri
Copy link
Contributor Author

jenkins test api

@cbodley cbodley merged commit c0c035e into ceph:main Jul 10, 2025
13 checks passed
@soumyakoduri soumyakoduri deleted the wip-skoduri-zoneparams-vers branch March 6, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants