Skip to content

Add normalization and casesensitive options to the subvolume group creation command#64324

Merged
vshankar merged 4 commits intoceph:mainfrom
xhernandez:volumegroup-casesensitive
Sep 11, 2025
Merged

Add normalization and casesensitive options to the subvolume group creation command#64324
vshankar merged 4 commits intoceph:mainfrom
xhernandez:volumegroup-casesensitive

Conversation

@xhernandez
Copy link
Contributor

This PR adds the same options to configure unicode normalization and case sensitivity already present for the subvolume creation command to the subvolume group creation command.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@xhernandez xhernandez marked this pull request as ready for review July 3, 2025 14:26
@xhernandez xhernandez requested a review from a team as a code owner July 3, 2025 14:26
@xhernandez
Copy link
Contributor Author

@batrick @vshankar could you take a look, please ?

Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@xhernandez xhernandez force-pushed the volumegroup-casesensitive branch from 0637e3d to 2ee7a11 Compare July 22, 2025 06:41
@batrick
Copy link
Member

batrick commented Jul 22, 2025

jenkins test make check

@xhernandez
Copy link
Contributor Author

jenkins test make check

1 similar comment
@xhernandez
Copy link
Contributor Author

jenkins test make check

Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
@xhernandez xhernandez force-pushed the volumegroup-casesensitive branch from 2ee7a11 to b47bbf8 Compare September 3, 2025 08:49
@xhernandez
Copy link
Contributor Author

jenkins test make check

@xhernandez
Copy link
Contributor Author

jenkins test windows

@xhernandez
Copy link
Contributor Author

jenkins test api

@xhernandez
Copy link
Contributor Author

jenkins test api

1 similar comment
@xhernandez
Copy link
Contributor Author

jenkins test api

@xhernandez
Copy link
Contributor Author

@vshankar all tests passed. If there's nothing else to do, could you merge it, please ?

@vshankar
Copy link
Contributor

@vshankar all tests passed. If there's nothing else to do, could you merge it, please ?

I will run this through fs:volume today before merging.

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/72954.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
@vshankar
Copy link
Contributor

@xhernandez I fixed up the test case a bit since it has a bug. fs:volumes runs fine. See: https://pulpito.ceph.com/?branch=wip-vshankar-testing-20250910.085256-debug

@vshankar vshankar merged commit 3f51eeb into ceph:main Sep 11, 2025
13 checks passed
@xhernandez xhernandez deleted the volumegroup-casesensitive branch September 15, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants