Skip to content

mds: include auth credential in session dump#64308

Merged
vshankar merged 1 commit intoceph:mainfrom
batrick:i71937
Jul 25, 2025
Merged

mds: include auth credential in session dump#64308
vshankar merged 1 commit intoceph:mainfrom
batrick:i71937

Conversation

@batrick
Copy link
Member

@batrick batrick commented Jul 2, 2025

This looks like:

[
    {
        "id": 4446,
        "auth_name": {
            "type": 16,
            "id": "x"
        },
    ...

Which would indicate it's a ceph-mgr with id "x".

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added the cephfs Ceph File System label Jul 2, 2025
This looks like:

    [
        {
            "id": 4446,
            "auth_name": {
                "type": 16,
                "id": "x"
            },
        ...

Which would indicate it's a ceph-mgr with id "x".

Fixes: https://tracker.ceph.com/issues/71937
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick batrick requested a review from a team July 2, 2025 16:07
@batrick
Copy link
Member Author

batrick commented Jul 2, 2025

Note: this "auth_name" will include a "type_str" field in an upcoming cephx change. That will be picked up automatically when that's merged.

@dparmar18
Copy link
Contributor

jenkins test make check arm64

@dparmar18
Copy link
Contributor

jenkins test make check

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just a nit and probably unrelated: human-readable type might be a bit better.

@batrick
Copy link
Member Author

batrick commented Jul 3, 2025

LGTM

Just a nit and probably unrelated: human-readable type might be a bit better.

#64308 (comment)

@batrick
Copy link
Member Author

batrick commented Jul 7, 2025

jenkins test make check arm64

3 similar comments
@batrick
Copy link
Member Author

batrick commented Jul 8, 2025

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Jul 9, 2025

jenkins test make check arm64

@batrick
Copy link
Member Author

batrick commented Jul 10, 2025

jenkins test make check arm64

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/72210.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit acee0c0 into ceph:main Jul 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System needs-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants