qa: Fix test_with_health_warn_with_2_active_MDSs#64297
Merged
Conversation
Contributor
Author
|
Test scheduled agains main branch here - https://pulpito.ceph.com/khiremat-2025-07-02_05:18:19-fs:functional-main-distro-default-smithi/ |
8723e64 to
131ce06
Compare
Contributor
Author
There was a typo |
Contributor
Author
|
New run with main branch - https://pulpito.ceph.com/khiremat-2025-07-02_07:03:50-fs:functional-main-distro-default-smithi/ |
rishabh-d-dave
requested changes
Jul 2, 2025
131ce06 to
0483e61
Compare
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
Author
|
jenkins test make check |
The test intended to validate the failure of 'mds fail' cmd on any active mds when one of them has warning. The commit 2217002 (PR 61554) changes this behavior and allows 'mds fail' on mds without the warning. The test should have always failed with this commit. But the test never failed until tested extensively because the test mostly generated warnings for both active mdses. Occasionaly, the test generated a warning on single mds and failed. So it's a race. This patch fixes the same by changing the following. a. Changed the mds_cache_memory_limit to '50K' from '1K' as '1K' was to less and generating warning on both the mdses. b. Create a directory and pin it a single mds and open 400 files in the backend to create cache pressure on one mds. Also, there are two tests with the same name as 'test_with_health_warn_with_2_active_MDSs' but in different classes though. So changed the test name to 'test_with_health_warn_on_1_mds_with_2_active_MDSs' to avoid confusion and indicate what the test actually does. Fixes: https://tracker.ceph.com/issues/71915 Signed-off-by: Kotresh HR <khiremat@redhat.com>
0483e61 to
f990e7d
Compare
Contributor
Author
|
jenkins test make check |
rishabh-d-dave
approved these changes
Jul 14, 2025
vshankar
approved these changes
Jul 21, 2025
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/72210. |
vshankar
approved these changes
Jul 25, 2025
This was referenced Sep 3, 2025
This was referenced Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test intended to validate the failure of 'mds fail'
cmd on any active mds when one of them has warning.
The commit 2217002
(PR 61554) changes this behavior and allows 'mds fail'
on mds without the warning. The test should have always
failed with this commit. But the test never failed until
tested extensively because the test mostly generated
warnings for both active mdses. Occasionaly, the test
generated a warning on single mds and failed. So it's a
race. This patch fixes the same by changing the following.
a. Changed the mds_cache_memory_limit to '50K' from '1K'
as '1K' was to less and generating warning on both the mdses.
b. Create a directory and pin it a single mds and open 400 files
in the backend to create cache pressure on one mds.
Also, there are two tests with the same name as
'test_with_health_warn_with_2_active_MDSs' but in different classes
though. So changed the test name to
'test_with_health_warn_on_1_mds_with_2_active_MDSs' to avoid
confusion and indicate what the test actually does.
Fixes: https://tracker.ceph.com/issues/71915
Signed-off-by: Kotresh HR khiremat@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition