Skip to content

qa: Fix test_with_health_warn_with_2_active_MDSs#64297

Merged
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:fix-test_admin-mds-fail
Jul 25, 2025
Merged

qa: Fix test_with_health_warn_with_2_active_MDSs#64297
vshankar merged 1 commit intoceph:mainfrom
kotreshhr:fix-test_admin-mds-fail

Conversation

@kotreshhr
Copy link
Contributor

@kotreshhr kotreshhr commented Jul 2, 2025

The test intended to validate the failure of 'mds fail'
cmd on any active mds when one of them has warning.

The commit 2217002
(PR 61554) changes this behavior and allows 'mds fail'
on mds without the warning. The test should have always
failed with this commit. But the test never failed until
tested extensively because the test mostly generated
warnings for both active mdses. Occasionaly, the test
generated a warning on single mds and failed. So it's a
race. This patch fixes the same by changing the following.

a. Changed the mds_cache_memory_limit to '50K' from '1K'
as '1K' was to less and generating warning on both the mdses.
b. Create a directory and pin it a single mds and open 400 files
in the backend to create cache pressure on one mds.

Also, there are two tests with the same name as
'test_with_health_warn_with_2_active_MDSs' but in different classes
though. So changed the test name to
'test_with_health_warn_on_1_mds_with_2_active_MDSs' to avoid
confusion and indicate what the test actually does.

Fixes: https://tracker.ceph.com/issues/71915
Signed-off-by: Kotresh HR khiremat@redhat.com

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System tests labels Jul 2, 2025
@kotreshhr kotreshhr requested review from a team and rishabh-d-dave July 2, 2025 05:00
@kotreshhr
Copy link
Contributor Author

@kotreshhr kotreshhr force-pushed the fix-test_admin-mds-fail branch from 8723e64 to 131ce06 Compare July 2, 2025 07:01
@kotreshhr
Copy link
Contributor Author

kotreshhr commented Jul 2, 2025

Test scheduled agains main branch here - https://pulpito.ceph.com/khiremat-2025-07-02_05:18:19-fs:functional-main-distro-default-smithi/

There was a typo s/pretty-json/json-pretty Fixed it

@kotreshhr
Copy link
Contributor Author

@kotreshhr kotreshhr force-pushed the fix-test_admin-mds-fail branch from 131ce06 to 0483e61 Compare July 8, 2025 08:24
@kotreshhr
Copy link
Contributor Author

jenkins test make check

1 similar comment
@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr kotreshhr requested a review from a team July 9, 2025 06:51
The test intended to validate the failure of 'mds fail'
cmd on any active mds when one of them has warning.

The commit 2217002
(PR 61554) changes this behavior and allows 'mds fail'
on mds without the warning. The test should have always
failed with this commit. But the test never failed until
tested extensively because the test mostly generated
warnings for both active mdses. Occasionaly, the test
generated a warning on single mds and failed. So it's a
race. This patch fixes the same by changing the following.

 a. Changed the mds_cache_memory_limit to '50K' from '1K'
    as '1K' was to less and generating warning on both the mdses.
 b. Create a directory and pin it a single mds and open 400 files
    in the backend to create cache pressure on one mds.

Also, there are two tests with the same name as
'test_with_health_warn_with_2_active_MDSs' but in different classes
though. So changed the test name to
'test_with_health_warn_on_1_mds_with_2_active_MDSs' to avoid
confusion and indicate what the test actually does.

Fixes: https://tracker.ceph.com/issues/71915
Signed-off-by: Kotresh HR <khiremat@redhat.com>
@rishabh-d-dave rishabh-d-dave self-assigned this Jul 9, 2025
@kotreshhr kotreshhr force-pushed the fix-test_admin-mds-fail branch from 0483e61 to f990e7d Compare July 9, 2025 07:06
@kotreshhr
Copy link
Contributor Author

jenkins test make check

@kotreshhr kotreshhr requested a review from a team July 15, 2025 06:30
@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/72210.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cephfs Ceph File System tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants