rgw/s3: fix PutObject's canned_acl comparisons for BlockPublicAcls#64290
Merged
rgw/s3: fix PutObject's canned_acl comparisons for BlockPublicAcls#64290
Conversation
canned_acl.compare() returns 0 for matches, so this was rejecting all canned acls Fixes: https://tracker.ceph.com/issues/49135 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
test case in ceph/s3-tests#668 fails against main with:
and passes against this pr |
adamemerson
approved these changes
Jul 2, 2025
Contributor
|
jenkins test make check |
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-pull-requests/162016/
|
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-pull-requests-arm64/76744/
|
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
theanalyst
approved these changes
Jul 9, 2025
Contributor
Author
|
https://jenkins.ceph.com/job/preserve-adarsha-ceph-pull-requests/8/
commented on https://tracker.ceph.com/issues/71243 |
Contributor
Author
|
jenkins test make check |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canned_acl.compare()returns 0 for matches, so this was rejecting all canned aclsFixes: https://tracker.ceph.com/issues/49135
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition