squid: mgr/vol: include group name in subvolume's pool namespace name#64205
Merged
chrisphoffman merged 5 commits intoceph:squidfrom Oct 10, 2025
Merged
squid: mgr/vol: include group name in subvolume's pool namespace name#64205chrisphoffman merged 5 commits intoceph:squidfrom
chrisphoffman merged 5 commits intoceph:squidfrom
Conversation
Include subvolume group name along with subvolume name in the pool namepsace string for the subvolume. IOW, include it in the string that serves as the value of the extended attribute "ceph.dir.layout.pool_namespace", which is set for a subvolume during its creation. Right now, due to not including it, two different subvolumes with same name but located in different subvolume groups undesirably end up in the same namespace. Fixes: https://tracker.ceph.com/issues/70668 Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 45f8aba)
Remove extra space from the line that defines the method name and parameters as the extra space between the keyword "def" and method name makes it impossible to find this method through a search. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 94ab44c)
Test that subvolume group name is included in the string that serves as the name of pool namespace for a subvolume. IOW, that serves as value of the extended attribute "ceph.dir.layout.pool_namespace" for a subvolume. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit db8c3f9)
namespaces. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit 85d0d77)
Member
|
jenkins test api |
Member
|
This PR is under test in https://tracker.ceph.com/issues/72654. |
chrisphoffman
requested changes
Sep 26, 2025
namespace of CephFS volumes. Signed-off-by: Rishabh Dave <ridave@redhat.com> (cherry picked from commit f350d98)
2603001 to
45aeaa2
Compare
Contributor
Author
|
@chrisphoffman @joscollin I've fixed the issue in release notes. |
Member
@chrisphoffman |
chrisphoffman
approved these changes
Oct 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/71854
backport of #62668
parent tracker: https://tracker.ceph.com/issues/70668
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh