Skip to content

rgw/notifications: add http request timeout and max inflight#64110

Merged
yuvalif merged 1 commit intoceph:mainfrom
yuvalif:wip-yuval-71402
Jul 7, 2025
Merged

rgw/notifications: add http request timeout and max inflight#64110
yuvalif merged 1 commit intoceph:mainfrom
yuvalif:wip-yuval-71402

Conversation

@yuvalif
Copy link
Contributor

@yuvalif yuvalif commented Jun 23, 2025

also make connection timeout configurable

Fixes: https://tracker.ceph.com/issues/71402

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@yuvalif
rgw/notifications: add http request timeout and max inflight
8a2e7bf 
also make connection timeout configurable

Fixes: https://tracker.ceph.com/issues/71402

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
@yuvalif yuvalif requested review from a team as code owners June 23, 2025 10:40
@github-actions
Copy link

github-actions bot commented Jun 23, 2025

Config Diff Tool Output

+ added: rgw_http_notif_connection_timeout (rgw.yaml.in)
+ added: rgw_http_notif_max_inflight (rgw.yaml.in)
+ added: rgw_http_notif_message_timeout (rgw.yaml.in)

The above configuration changes are found in the PR. Please update the relevant release documentation if necessary.
Ignore this comment if docs are already updated. To make the "Check ceph config changes" CI check pass, please comment /config check ok and re-run the test.

@yuvalif yuvalif mentioned this pull request Jun 23, 2025
Closed
14 tasks
@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 23, 2025

regarding this comment (from the original PR): #63404 (review)
and a similar comment (from another PR): #64010 (comment)

once this PR is merged: #64010
I will followup on the issue, and move to idle state when I get an error code of -EBUSY

@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 24, 2025 •
edited
Loading

/config check ok

@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 24, 2025

jenkins test make check

@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 24, 2025

jenkins test make check arm64

@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 24, 2025

jenkins test make check

@yuvalif yuvalif mentioned this pull request Jun 24, 2025
Merged
14 tasks
@yuvalif
Copy link
Contributor Author

yuvalif commented Jun 26, 2025

jenkins test make check

@yuvalif
Copy link
Contributor Author

yuvalif commented Jul 1, 2025

bucket notifications tests are failing on expected issues:
https://pulpito.ceph.com/yuvalif-2025-06-26_10:42:26-rgw:notifications-wip-yuval-71402-distro-default-smithi/

  • valgrind issue
  • kafka failover issue

rgw regression: https://pulpito.ceph.com/yuvalif-2025-06-26_10:43:57-rgw-wip-yuval-71402-distro-default-smithi/
rerun: https://pulpito.ceph.com/yuvalif-2025-06-30_11:08:13-rgw-wip-yuval-71402-distro-default-smithi/
re-rerun: https://pulpito.ceph.com/yuvalif-2025-06-30_13:25:26-rgw-wip-yuval-71402-distro-default-smithi/
3rd rerun: https://pulpito.ceph.com/yuvalif-2025-07-01_06:24:16-rgw-wip-yuval-71402-distro-default-smithi/
all issues are known or seen elsewhere as well:

  • d4n
  • kafka failover
  • notification valgrind
  • multisite
  • radosgw-admin failure

@yuvalif
Copy link
Contributor Author

yuvalif commented Jul 1, 2025

jenkins test make check arm64

2 similar comments
@yuvalif
Copy link
Contributor Author

yuvalif commented Jul 2, 2025

jenkins test make check arm64

@yuvalif
Copy link
Contributor Author

yuvalif commented Jul 3, 2025

jenkins test make check arm64

@yuvalif yuvalif merged commit 0f1fed1 into ceph:main Jul 7, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamemerson adamemerson adamemerson approved these changes

Assignees

No one assigned

Labels

common config-change documentation needs-review rgw

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvalif @adamemerson