qa: Honor cephfs config from yaml across test cases#63902
qa: Honor cephfs config from yaml across test cases#63902
Conversation
|
Test to verify - QA run with fix - https://pulpito.ceph.com/khiremat-2025-06-12_09:30:24-fs:functional-main-distro-default-smithi/ |
|
jenkins test make check |
Please see below that the fs_config is properly picked up for each test run. |
|
QA Run without the fix using main branch: https://pulpito.ceph.com/khiremat-2025-06-12_10:24:03-fs:functional-main-distro-default-smithi/ Please see below the fs_config is not picked up from yaml. It's all empty. |
|
jenkins test make check |
f4b97ee to
c2d12a6
Compare
|
jenkins test dashboard cephadm |
20bec86 to
d70dd07
Compare
|
jenkins test make check |
|
jenkins test dashboard cephadm |
|
jenkins test make check |
batrick
left a comment
There was a problem hiding this comment.
For the stated example:
------
ceph:
cephfs:
allow_referent_inodes: true
max_mds: 2
fs:
- name: a
max_mds: 3
- name: b
------
many tests are not tolerant of a multiple rank fs. Nor would they be if there are multiple fs.
Otherwise, the idea of this fix is fine with me. Suggest removing those example configs from teh commit message, PR, and issue.
The cephfs_test_runner wasn't honoring the cephfs config passed via yaml. For each test case the filesystem is newly created and destroyed as part of setup and teardown. The filesystem creation is taken care by the class 'Filesystem' in which the 'fs_config' isn't initialised from yaml. Hence the filesystem is being created with default configs without honoring the configs passed from yaml. This patch fixes the same. Fixes: https://tracker.ceph.com/issues/71649 Signed-off-by: Kotresh HR <khiremat@redhat.com>
d70dd07 to
38c0e44
Compare
Yeah. I agree. But the fix isn't only for multiple rank fs. Even with single fs, the configs passed from yaml weren't picked up by the testcases run by cephfs_test_runner
Done. @batrick ptal. |
|
This PR is under test in https://tracker.ceph.com/issues/72416. |
|
jenkins test make check arm64 |
|
jenkins test dashboard cephadm |
1 similar comment
|
jenkins test dashboard cephadm |
|
I'm seeing failures is fs suite which haven't been seen before and could be a side-effect of this change. See: https://pulpito.ceph.com/vshankar-2025-08-08_06:01:33-fs-wip-vshankar-testing-20250807.165858-debug-testing-default-smithi/ @kotreshhr I would require your assistance to verify the above. |
This is a fs suite run without this change: https://pulpito.ceph.com/vshankar-2025-08-12_11:31:54-fs-wip-vshankar-testing-20250812.045652-debug-testing-default-smithi/ The failures seen in the original run are not seen in this run, so, somehow this change is causing spurious failures. @kotreshhr please investigate. |
Oh, this needs sometime to go through. I will update after going through the results |
|
This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days. |
|
This pull request has been automatically closed because there has been no activity for 90 days. Please feel free to reopen this pull request (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
The cephfs_test_runner wasn't honoring the cephfs config passed via yaml. For each test case the filesystem is newly created and destroyed as part of setup and teardown. The filesystem creation is taken care by the class 'Filesystem' in which the 'fs_config' isn't initialised from yaml. Hence the filesystem is being created with default configs without honoring the configs passed from yaml. This patch fixes the same.
Fixes: https://tracker.ceph.com/issues/71649
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition