Skip to content

qa/suites/crimson-rados: Accommodate to new crimson flavors#63833

Merged
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-flavor
Jun 15, 2025
Merged

qa/suites/crimson-rados: Accommodate to new crimson flavors#63833
Matan-B merged 3 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-flavor

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Jun 10, 2025

flavor crimson is deprecated, let the flavor to be set when passing --flavor/-f when scheduling jobs instead.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@Matan-B
qa/suties/crimson-rados: Don't override flavor
20c4f4f 
flavor crimson is deprecated, let the flavor to be set when passing --flavor/-f when
scheduling jobs instead.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B requested review from a team and cyx1231st June 10, 2025 07:47
@Matan-B Matan-B added this to Crimson Jun 10, 2025
cyx1231st
cyx1231st approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@cyx1231st cyx1231st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 10, 2025

jenkins test windows

@Matan-B Matan-B moved this to Tested in Crimson Jun 10, 2025
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 10, 2025

jenkins test api

@Matan-B Matan-B mentioned this pull request Jun 10, 2025
Merged
14 tasks
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 11, 2025

Run looks odd:
https://pulpito.ceph.com/matan-2025-06-10_17:34:03-crimson-rados-main-distro-crimson-debug-smithi/

Perhaps we need this some of the flavor mentions? Looking

@Matan-B Matan-B moved this from Tested to Needs QA in Crimson Jun 11, 2025
@cyx1231st cyx1231st mentioned this pull request Jun 12, 2025
Merged
14 tasks
@Matan-B Matan-B requested a review from a team as a code owner June 12, 2025 08:30
@Matan-B Matan-B force-pushed the wip-matanb-crimson-flavor branch from 39e6c4d to c4199c7 Compare June 12, 2025 08:32
Matan-B added 2 commits June 12, 2025 09:26
@Matan-B
qa/tasks: update crimson flavor types
83d556b 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B
container: update crimson flavors
425b6da 
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-flavor branch from c4199c7 to 425b6da Compare June 12, 2025 09:26
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 12, 2025

This work now
https://pulpito.ceph.com/matan-2025-06-12_09:27:43-crimson-rados-main-distro-crimson-debug-smithi/

@Matan-B Matan-B moved this from Needs QA to Tested in Crimson Jun 12, 2025
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 12, 2025

jenkins test make check arm64

@Matan-B Matan-B changed the title qa/suties/crimson-rados: Don't override flavor qa/suties/crimson-rados: Accommodate to new crimson flavors Jun 12, 2025
@Matan-B Matan-B changed the title qa/suties/crimson-rados: Accommodate to new crimson flavors qa/suites/crimson-rados: Accommodate to new crimson flavors Jun 12, 2025
@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 12, 2025 •
edited
Loading

This is ready to merge and is required for scheduling runs, waiting for makecheck64 to pass

@cyx1231st
Copy link
Member

cyx1231st commented Jun 13, 2025

My command is:

teuthology-suite -m smithi -e <mail> -f crimson-debug -s crimson-rados -p <prio>
-c ci-yingxin-start-stop-trim-dirty --suite-repo https://github.com/Matan-B/ceph.git
--suite-branch wip-matanb-crimson-flavor--filter-all seastore --limit 10

The command is failed by:

teuthology.exceptions.VersionNotFoundError:
Failed to fetch package version from
https://shaman.ceph.com/api/search/?status=ready&project=ceph&flavor=crimson-debug&distros=centos%2F8%2Fx86_64&sha1=1141f4b2b796c8164bc2e978b3d9a562651df835

Look into the URL above, the query is somehow looking at an invalid distros centos/8/x86_64, and the URL is working after fixing the version from 8 to 9:

https://shaman.ceph.com/api/search/?status=ready&project=ceph&flavor=crimson-debug&distros=centos%2F9%2Fx86_64&sha1=1141f4b2b796c8164bc2e978b3d9a562651df835

So seems there is still a wrong default somewhere.

@Matan-B
Copy link
Contributor Author

Matan-B commented Jun 15, 2025

@cyx1231st, the above command worked well for me:
https://pulpito.ceph.com/matan-2025-06-15_07:55:47-crimson-rados-ci-yingxin-start-stop-trim-dirty-distro-crimson-debug-smithi/

Can you try specifying the distro perhaps?

@Matan-B Matan-B merged commit 5fd7383 into ceph:main Jun 15, 2025
15 of 21 checks passed
@Matan-B Matan-B moved this from Tested to Merged (Main) in Crimson Jun 15, 2025
@cyx1231st
Copy link
Member

cyx1231st commented Jun 16, 2025

@Matan-B Thanks for scheduling the run!

I added -f crimson-debug -d centos -D 9, and it scheduled successfully.

@Matan-B Matan-B mentioned this pull request Jun 16, 2025
Merged
@Matan-B Matan-B mentioned this pull request Jun 23, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cyx1231st cyx1231st cyx1231st approved these changes

Assignees

No one assigned

Labels

build/ops cephadm crimson ready-to-merge rook tests

Projects

Crimson
Status: Merged (Main)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Matan-B @cyx1231st