test/osd/types.cc: fix memory leak in pg_pool_t encodeDecode test#63820
Closed
test/osd/types.cc: fix memory leak in pg_pool_t encodeDecode test#63820
Conversation
Fix a memory leak where test instances created by
pg_pool_t::generate_test_instances() were not being freed after use.
The generate_test_instances() method follows the convention of returning
raw pointers (used by ceph-dencoder for encoder/decoder verification),
but the test was not cleaning up these allocated instances.
ASan reported a 712-byte leak traced to the test instance allocation.
```
Direct leak of 712 byte(s) in 1 object(s) allocated from:
#0 0x555e7e3d94cd in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_osd_types+0x29a4cd) (BuildId: e6de649d
bc3dc2f253818f12b47cae5ff3507a89)
#1 0x7fdd87bb9bd7 in pg_pool_t::generate_test_instances(std::__cxx11::list<pg_pool_t*, std::allocator<pg_pool_t*>>&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.cc:2349:15
#2 0x555e7e3e3759 in pg_pool_t_encodeDecode_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/types.cc:124:5
#3 0x555e7e5fd3dd in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2653:10
#4 0x555e7e5c1a35 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2689:14`
```
This change adds proper cleanup by deleting the test instances after
the encode/decode verification is complete.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Contributor
Author
|
i will consider a more intrusive way to return, for instance created #63910 |
Contributor
Author
|
jenkins test make check arm64 |
14 tasks
Contributor
Author
|
jenkins test submodules |
1 similar comment
Contributor
Author
|
jenkins test submodules |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
closing in favor of #63910 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a memory leak where test instances created by
pg_pool_t::generate_test_instances() were not being freed after use.
The generate_test_instances() method follows the convention of returning raw pointers (used by ceph-dencoder for encoder/decoder verification), but the test was not cleaning up these allocated instances.
ASan reported a 712-byte leak traced to the test instance allocation.
This change adds proper cleanup by deleting the test instances after the encode/decode verification is complete.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition