.gitmodules: remove shallow=true config from nvmeof/gateway#63729
Merged
.gitmodules: remove shallow=true config from nvmeof/gateway#63729
Conversation
ceph#61264 reintroduced https://tracker.ceph.com/issues/67640 fixed by 383091e. Setting shallow=true for the nvmeof/gateway submodule is problematic because the ceph.git submodule sha1 is only very rarely the head sha1 of the default branch. Fixes: https://tracker.ceph.com/issues/71568 Signed-off-by: Samuel Just <sjust@redhat.com>
tchaikov
approved these changes
Jun 5, 2025
Contributor
|
hi @chardan and @irq0, sorry for merging this change without your reviews which were requested by Sam, because this is apparently a regression, and per https://tracker.ceph.com/issues/71568, this should addressed ASAP. so i took the liberty and merged it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#61264 reintroduced https://tracker.ceph.com/issues/67640 fixed by
383091e.
Setting shallow=true for the nvmeof/gateway submodule is problematic because the ceph.git submodule sha1 is only very rarely the head sha1 of the default
branch.
Fixes: https://tracker.ceph.com/issues/71568
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition