Skip to content

debian: radosgw: add media-types packages as alternative for mime-support#63702

Merged
cbodley merged 1 commit intoceph:mainfrom
ThomasLamprecht:deb-radosgw-media-types-dependency
Jun 4, 2025
Merged

debian: radosgw: add media-types packages as alternative for mime-support#63702
cbodley merged 1 commit intoceph:mainfrom
ThomasLamprecht:deb-radosgw-media-types-dependency

Conversation

@ThomasLamprecht
Copy link
Contributor

Back in 2020 the '/etc/mime.types' file was split out into its own leaner 'media-types' Debian package 0, the previous 'mime-support' was kept as transitional package to handle upgrades, but it did its job and isn't included in Debian Trixie repos anymore.

So accept both, the new 'media-types' package or the legacy 'mime-support' one as valid dependency for radosgw, this ensures one can install radosgw on newer Debian based releases while keeping it also working for older ones.

Fixes: https://tracker.ceph.com/issues/71545

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

…port

Back in 2020 the '/etc/mime.types' file was split out into it's own
leaner 'media-types' Debian package [0], the previous 'mime-support'
was kept as transitional package to handle upgrades, but it did its
job and isn't included in Debian Trixie repos anymore.

So accept both, the new 'media-types' package or the legacy
'mime-support' one as valid dependency for radosgw, this ensures one
can install radosgw on newer Debian based releases while keeping it
also working for older ones.

[0]: https://salsa.debian.org/debian/media-types/-/commit/4d6ff19de5720196b40cf65f1173bd9333dfecf9

Fixes: https://tracker.ceph.com/issues/71545
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor

tchaikov commented Jun 4, 2025

the test failures are irrelevant. tracked by https://tracker.ceph.com/issues/71547

@tchaikov
Copy link
Contributor

tchaikov commented Jun 4, 2025

jenkins test make check

@cbodley
Copy link
Contributor

cbodley commented Jun 4, 2025

thanks @ThomasLamprecht @tchaikov, i pushed this branch to ceph-ci to make sure debian builds succeed. pending in https://shaman.ceph.com/builds/ceph/pr-63702/

@cbodley
Copy link
Contributor

cbodley commented Jun 4, 2025

thanks @ThomasLamprecht @tchaikov, i pushed this branch to ceph-ci to make sure debian builds succeed. pending in https://shaman.ceph.com/builds/ceph/pr-63702/

green in https://shaman.ceph.com/builds/ceph/pr-63702/87ac378f9765e52f4c69178f86996e429d0384f3/ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants