rgw/multisite: Fix lifetime issues#63698
Merged
adamemerson merged 5 commits intoceph:mainfrom Aug 6, 2025
Merged
Conversation
a1dab81 to
c95d6b0
Compare
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
@cbodley I think this fixes it, at least I can't reproduce it any more. |
cbodley
reviewed
Jun 5, 2025
Contributor
cbodley
left a comment
There was a problem hiding this comment.
shared_ptr changes look good 👍
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
cbodley
reviewed
Jun 26, 2025
99705ff to
a465666
Compare
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
cbodley
reviewed
Jul 11, 2025
9a94c4d to
7457e83
Compare
Contributor
Author
|
Rebase broke something, investigating. |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
5c41f2b to
fa9d0cb
Compare
cbodley
approved these changes
Aug 4, 2025
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
Asynchrony combined with cancellations keeps leading to occasional lifetime issues, so follow the best-practices of Asio I/O objects by having completions keep a reference live. The original NeoRados backing implements Asio's two-phase shutdown properly. The RadosClient backing does not, because it shares an Objecter with completions that do not belong to it. In practice I don't think this will matter since librados and neorados get shut down around the same time. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Also run them in strands. Also `datalog_rados` is a `shared_ptr`, now. Probably make it intrusive later. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Tag operations with a subsystem so we can cancel them all in one go. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Split nominal handle object and reference-counted implementation. While we're at it, add lazy-open functionality. Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
This is slightly ugly but good enough for now. Make sure we can block when shutting down background tasks. Remove a few `driver` parameters that are unused. This lets us simplify the IAM Policy and Lua tests and not construct stores we never use. (Which is good since we aren't running them under a cluster.) Signed-off-by: Adam C. Emerson <aemerson@redhat.com>
Contributor
|
yay! |
batrick
reviewed
Aug 11, 2025
| auto num = s.substr(0, pos); | ||
| auto ofs = s.substr(pos + 1); | ||
|
|
||
| auto n = ceph::parse<decltype(m.num)>(num); |
Member
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/71066
Fixes: https://tracker.ceph.com/issues/72211
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition