mds: wrong snap check for directory with parent snaps#63524
Merged
mds: wrong snap check for directory with parent snaps#63524
Conversation
This test is checking for failure conditions. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> Fixes: https://tracker.ceph.com/issues/71462
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> Fixes: https://tracker.ceph.com/issues/71462
If the parent directory has snapshots but the child was created after, then we should be able to modify its charmap. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> Fixes: https://tracker.ceph.com/issues/71462
To look if the directory's first is beyond the last snap. This matches the behavior of lssnaps. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> Fixes: https://tracker.ceph.com/issues/71462
Contributor
rishabh-d-dave
left a comment
There was a problem hiding this comment.
Just some nits I had in mind when I reviewed this PR few days ago.
Comment on lines
9243
to
+9244
| SnapRealm *realm = diri->find_snaprealm(); | ||
| return !realm->get_snaps().empty(); | ||
| auto& snaps = realm->get_snaps(); |
Contributor
There was a problem hiding this comment.
nit: since realm is not used anywhere else in this method -
Suggested change
| SnapRealm *realm = diri->find_snaprealm(); | |
| return !realm->get_snaps().empty(); | |
| auto& snaps = realm->get_snaps(); | |
| auto& snaps = diri->find_snaprealm()->get_snaps(); |
Comment on lines
+9245
to
+9246
| auto it = snaps.lower_bound(diri->get_oldest_snap()); | ||
| return it != snaps.end(); |
Contributor
There was a problem hiding this comment.
nit: I find following more succinct -
Suggested change
| auto it = snaps.lower_bound(diri->get_oldest_snap()); | |
| return it != snaps.end(); | |
| return snaps.lower_bound(diri->get_oldest_snap()) != snaps.end(); |
Contributor
There was a problem hiding this comment.
This is not succinct - readability is far more important than writing compact code which essentially does this same thing.
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/72210. |
vshankar
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition