Conversation
3298e14 to
ba7db79
Compare
Contributor
|
wai? |
Contributor
Author
Apologies - I didn't quite get that. |
Contributor
|
Suggesting adding some rationale for the reversion to the PR description. |
Contributor
Author
Fair enough. I created this revert via GitHub UI which does bare minimum if putting description. I'll add some... |
PR #53989 is causing failures in fs:upgrade. Also, @VallariAg reported an issue with something similar. I don't think adequate tests were run to qualify the PR as mergeable. Reverting the change for now. Signed-off-by: Venky Shankar <vshankar@redhat.com>
ba7db79 to
ddb86b7
Compare
Contributor
Author
|
Commit message and PR updated. |
Contributor
Author
|
jenkins test make check |
Contributor
Author
|
jenkins test make check arm64 |
2 similar comments
Member
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check arm64 |
Contributor
|
jenkins test make check arm64 |
2 similar comments
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #53989 is causing failures in
fs:upgrade. Also, @VallariAg reported an issue with something
similar. I don't think adequate tests were run to qualify the PR
as mergeable. Reverting the change for now.
Signed-off-by: Venky Shankar vshankar@redhat.com
Reverts #53989