mgr/vol: make "snapshot getpath" cmd return ENOTSUP for v1#63123
mgr/vol: make "snapshot getpath" cmd return ENOTSUP for v1#63123rishabh-d-dave wants to merge 3 commits intoceph:mainfrom
Conversation
3ba1f7e to
7c80e22
Compare
|
With vstart_runner.py, tests ran fine. I am getting them to run in Sepia lab as well now. |
Return ENOTSUP when "ceph fs subvolume snapshot getpath" command is run for subvolume v1. Fixes: https://tracker.ceph.com/issues/70834 Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Signed-off-by: Rishabh Dave <ridave@redhat.com>
7c80e22 to
7cdbbef
Compare
| if subvol.version() == 1: | ||
| ret = (-errno.ENOTSUP, '', | ||
| 'command not supported for v1 subvolumes') | ||
| return ret |
There was a problem hiding this comment.
Normally I would expect v1 to implement snapshot_data_path as a method which always returns -ENOTSUP rather than special case here.
Won't stop approval though. Please clean up in a future PR.
There was a problem hiding this comment.
Also, let's add another TODO to have some command from the volumes plugin tell us how many v1/v2/v3 subvols there (any upgrades done, if applicable). That could be collected by telemetry.
There was a problem hiding this comment.
Normally I would expect v1 to implement snapshot_data_path as a method which always returns -ENOTSUP rather than special case here.
snapshot_data_path() is already implemented which is why I added this block of code here - https://github.com/ceph/ceph/blob/main/src/pybind/mgr/volumes/fs/operations/versions/subvolume_v1.py#L84-L86
There was a problem hiding this comment.
Wait I'm confused now. You're saying v1 could support the command but we're choosing not to?
There was a problem hiding this comment.
I think the concern was something related to retained snaps in v1.
|
jenkins test make check |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
Decision was made to support |
Return ENOTSUP when "ceph fs subvolume snapshot getpath" command is run
for subvolume v1.
Fixes: https://tracker.ceph.com/issues/70834
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition