test/rgw: ensure proper cleanup in Kafka idle behaviour notification test#63015
test/rgw: ensure proper cleanup in Kafka idle behaviour notification test#63015VinayakTiwari1103 wants to merge 1 commit intoceph:mainfrom
Conversation
…test Added a try-finally block in the `test_ps_s3_notification_kafka_idle_behaviour` function to guarantee cleanup of S3 notifications, topics, and buckets, even if the test encounters failures. This change addresses potential issues where incomplete cleanup could lead to Teuthology job failures during the garbage collection or user purge phase. Also replaced floating-point division with integer division in the status assertion to ensure reliable HTTP status code validation. These improvements enhance test reliability, prevent leftover resources, and reduce the risk of post-test administrative command failures. Signed-off-by: Vinayak Tiwari Signed-off-by: Vinayak Tiwari <84216407+VinayakTiwari1103@users.noreply.github.com>
|
Can one of the admins verify this patch? |
|
@VinayakTiwari1103 teuthology failures are due to an RGW crash. not a test cleanup issue. |
Hi @yuvalif , Best, |
i think the crash was already fixed. just trying to make sure the fix was backported to "squid" |
|
Thanks, @yuvalif and @VinayakTiwari1103. |
|
closing based on the above discussion |
Ensure proper cleanup in
test_ps_s3_notification_kafka_idle_behaviourby adding a try-finally block to handle S3 notifications, topics, and bucket deletion. This prevents Teuthology failures due to incomplete cleanup during GC or user purge.Also corrected status assertion by using integer division for better reliability.
Fixes: https://tracker.ceph.com/issues/71114
Signed-off-by: Vinayak Tiwari tiwarivinayak10@gmail.com
Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition