Skip to content

D4N Test Updates#62982

Merged
ivancich merged 5 commits intoceph:mainfrom
samarahu:wip-rgw-d4n-next-test
Jul 16, 2025
Merged

D4N Test Updates#62982
ivancich merged 5 commits intoceph:mainfrom
samarahu:wip-rgw-d4n-next-test

Conversation

@samarahu
Copy link
Contributor

@samarahu samarahu commented Apr 25, 2025 •
edited
Loading

These fixes allow the D4N suite and unit test programs to pass. Note: removal of D4N subsuite from RGW suite must be reversed in Tentacle branch. Backports to the Tentacle branch are necessary.

The most recent commit addresses the following tracker issue: https://tracker.ceph.com/issues/71088

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@samarahu samarahu force-pushed the wip-rgw-d4n-next-test branch from 0ecbecb to d262387 Compare May 27, 2025 18:46
@samarahu samarahu force-pushed the wip-rgw-d4n-next-test branch 2 times, most recently from bf6618a to 895e088 Compare June 18, 2025 19:09
@samarahu samarahu changed the title (DNM) D4N Suite and Filter Test Updates (DNM) D4N Test Program Updates Jun 18, 2025
@samarahu samarahu changed the title (DNM) D4N Test Program Updates D4N Test Program Updates Jun 18, 2025
This was referenced Jun 18, 2025
Merged
Merged
@samarahu samarahu force-pushed the wip-rgw-d4n-next-test branch from 895e088 to 0cab842 Compare June 25, 2025 17:00
@github-actions
Copy link

github-actions bot commented Jun 25, 2025

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@pritha-srivastava
Copy link
Contributor

pritha-srivastava commented Jun 30, 2025

some failures we are seeing in make check are:

  1. E: Unable to locate package clang-16
  2. *** Caught signal (Segmentation fault) **
    in thread 7f8ea38c5100 thread_name:unittest_bluefs
    2025-06-27T14:13:14.516+0000 7f8ea38c5100 -1 WARNING: all dangerous and experimental features are enabled.
    2025-06-27T14:13:14.544+0000 7f8ea38c5100 1 bdev(0x5602de5fef00 ceph_test_bluefs.tmp.block.4008626.1) open path ceph_test_bluefs.tmp.block.4008626.1
    ceph version Development (no_version) tentacle (dev - Debug)
    1: /home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_bluefs(+0x3c0444) [0x5602dbfd1444]
    2: /lib/x86_64-linux-gnu/libc.so.6(+0x42520) [0x7f8ea44a3520]
    3: (ceph::mutex_debug_detail::mutex_debugging_base::is_locked_by_me() const+0xcb) [0x5602dbe809bb]
    4: (ceph::mutex_debug_detail::mutex_debug_impl::lock(bool)+0x25) [0x5602dbe80835]
    5: (std::lock_guard<ceph::mutex_debug_detail::mutex_debug_impl >::lock_guard(ceph::mutex_debug_detail::mutex_debug_impl&)+0x25) [0x5602dbe80755]
    6: (ceph::extblkdev::detect_device(ceph::common::CephContext*, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, std::shared_ptrceph::ExtBlkDevInterface&)+0x55) [0x5602dc0cf345]

@pritha-srivastava
Copy link
Contributor

pritha-srivastava commented Jun 30, 2025

jenkins test make check

@pritha-srivastava
Copy link
Contributor

pritha-srivastava commented Jun 30, 2025

jenkins test make check arm64

@samarahu samarahu force-pushed the wip-rgw-d4n-next-test branch from 9bbe93c to f6f0b46 Compare July 1, 2025 15:22
@ivancich
Copy link
Member

ivancich commented Jul 3, 2025

@pritha-srivastava @samarahu Should this have the needs-qa label on it?

@samarahu
Copy link
Contributor Author

samarahu commented Jul 7, 2025

@pritha-srivastava @samarahu Should this have the needs-qa label on it?

@ivancich Yes.

@samarahu
Copy link
Contributor Author

samarahu commented Jul 7, 2025

jenkins test make check

@samarahu
Copy link
Contributor Author

samarahu commented Jul 7, 2025

jenkins test make check arm64

@samarahu
Copy link
Contributor Author

samarahu commented Jul 7, 2025 •
edited
Loading

Most recent QA runs: https://pulpito.ceph.com/suriarte-2025-07-01_19:44:25-rgw-wip-rgw-d4n-next-test-distro-default-smithi/
Subsequent rerun of failed tests: https://pulpito.ceph.com/suriarte-2025-07-07_14:40:12-rgw-wip-rgw-d4n-next-test-distro-default-smithi/

These failures do not look as if they are caused by my changes.

@samarahu
Copy link
Contributor Author

samarahu commented Jul 8, 2025

jenkins test make check

@ivancich
Copy link
Member

ivancich commented Jul 10, 2025

@samarahu Is this ready to be merged?

@samarahu
Copy link
Contributor Author

samarahu commented Jul 11, 2025

@pritha-srivastava I believe so, because all of the failures from Teuthology testing do not seem related to my changes. However, the first commit in the PR has already been merged separately as a response to a tracker issue. I'd like to rebase the PR but should I entirely retest or is that not necessary?

@pritha-srivastava
Copy link
Contributor

pritha-srivastava commented Jul 14, 2025

@pritha-srivastava I believe so, because all of the failures from Teuthology testing do not seem related to my changes. However, the first commit in the PR has already been merged separately as a response to a tracker issue. I'd like to rebase the PR but should I entirely retest or is that not necessary?

I don't think you need to entirely retest this if the first commit is the exact same one. A rebase should be fine.

samarahu added 5 commits July 14, 2025 13:14
@samarahu
test/d4n: Set config_store_type to dbstore
8c578fc 
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
@samarahu
test/d4n: Add dout initalization during env setup
7c51f75 
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
@samarahu
test/d4n: Add length to bufferlist vars
8c6f891 
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
@samarahu
rgw/d4n: Add shutdown calls to unit tests and save yield in filter
a5dfb45 
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
@samarahu
qa/d4n: Update D4N suite
f08f709 
Signed-off-by: Samarah <samarah.uriarte@ibm.com>
@samarahu samarahu force-pushed the wip-rgw-d4n-next-test branch from f6f0b46 to f08f709 Compare July 14, 2025 16:23
@samarahu
Copy link
Contributor Author

samarahu commented Jul 15, 2025

jenkins test api

1 similar comment
@ivancich
Copy link
Member

ivancich commented Jul 15, 2025

jenkins test api

@samarahu
Copy link
Contributor Author

samarahu commented Jul 15, 2025

jenkins test api

2 similar comments
@samarahu
Copy link
Contributor Author

samarahu commented Jul 15, 2025

jenkins test api

@samarahu
Copy link
Contributor Author

samarahu commented Jul 15, 2025

jenkins test api

@ivancich ivancich merged commit 0dc9bd0 into ceph:main Jul 16, 2025
13 checks passed
@samarahu samarahu deleted the wip-rgw-d4n-next-test branch July 16, 2025 13:10
@samarahu samarahu mentioned this pull request Jul 23, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pritha-srivastava pritha-srivastava pritha-srivastava approved these changes

Assignees

No one assigned

Labels

ready-to-merge rgw TESTED tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samarahu @pritha-srivastava @ivancich @cbodley