Skip to content

qa: setup mount_b in test_mirroring.py#62949

Merged
joscollin merged 1 commit intoceph:mainfrom
joscollin:wip-test-mirroring-fix
Jul 3, 2025
Merged

qa: setup mount_b in test_mirroring.py#62949
joscollin merged 1 commit intoceph:mainfrom
joscollin:wip-test-mirroring-fix

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Apr 24, 2025

Adds a function to setup mount_b in test_mirroring.py. Avoids code repeat in each test function.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System tests labels Apr 24, 2025
@joscollin joscollin added the DNM label Apr 24, 2025
@joscollin joscollin force-pushed the wip-test-mirroring-fix branch from 68a629c to 0aad962 Compare April 25, 2025 06:14
@joscollin joscollin removed the DNM label Apr 25, 2025
@joscollin joscollin marked this pull request as ready for review April 25, 2025 14:54
@joscollin
Copy link
Member Author

@joscollin joscollin requested a review from a team April 28, 2025 03:33
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

@joscollin
Copy link
Member Author

@rishabh-d-dave Please add it to your qa batch.

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave Please add it to your qa batch.

I finished a QA run only a little while ago. If I do start a new batch, I'll pick this PR too.

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin joscollin force-pushed the wip-test-mirroring-fix branch from 0aad962 to 133cdb7 Compare May 13, 2025 05:11
@joscollin
Copy link
Member Author

Rebased.

@joscollin
Copy link
Member Author

jenkins test make check

@joscollin
Copy link
Member Author

jenkins test make check arm64

Copy link
Contributor

@rishabh-d-dave rishabh-d-dave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joscollin
Copy link
Member Author

jenkins test make check

@joscollin
Copy link
Member Author

jenkins test make check arm64

@hkadam134
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/71820.

@joscollin
Copy link
Member Author

@joscollin joscollin merged commit fba66ea into ceph:main Jul 3, 2025
12 checks passed
@joscollin joscollin deleted the wip-test-mirroring-fix branch July 3, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants