Skip to content

pybind/mgr/volumes: make casesensitive attr uniform in interface#62904

Merged
batrick merged 3 commits intoceph:mainfrom
batrick:i70996
Apr 29, 2025
Merged

pybind/mgr/volumes: make casesensitive attr uniform in interface#62904
batrick merged 3 commits intoceph:mainfrom
batrick:i70996

Conversation

@batrick
Copy link
Member

@batrick batrick commented Apr 21, 2025 •
edited
Loading

based on #62872

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@github-actions github-actions bot added cephfs Ceph File System pybind tests labels Apr 21, 2025
@batrick
Copy link
Member Author

batrick commented Apr 21, 2025

cc @xhernandez

@batrick batrick requested a review from a team as a code owner April 21, 2025 18:26
@batrick
Copy link
Member Author

batrick commented Apr 21, 2025

jenkins test api

@batrick
Copy link
Member Author

batrick commented Apr 21, 2025

This PR is under test in https://tracker.ceph.com/issues/71000.

@xhernandez
Copy link
Contributor

xhernandez commented Apr 22, 2025

I think that using --case-insensitive flag is more intuitive and clean, but I won't oppose if you prefer this change.

@batrick
Copy link
Member Author

batrick commented Apr 23, 2025

I think that using --case-insensitive flag is more intuitive and clean, but I won't oppose if you prefer this change.

In some ways it's tidier but here's why:

  • The inconsistency in the naming was flagged by QE as confusing and inconsistent. It's hard to disagree.
  • The user/admin/operator has to be extra clear that this is what they want: --casesensitive=0. Simply doing --casesensitive (IIRC from my testing) will have no effect. Since usually we want a case-sensitive file system, that seems like a more reasonable default.
  • The change in naming created a bug from the start (pybind/mgr/volumes: fix typo in casesensitive vxattr #62872) which is usually why we don't do unnecessarily name changes to begin with. (Believe me, there's plenty of names for things I disagree with but grudgingly accept.)

@batrick
Copy link
Member Author

batrick commented Apr 23, 2025

jenkins test make check arm64

1 similar comment
@batrick
Copy link
Member Author

batrick commented Apr 25, 2025

jenkins test make check arm64

@batrick batrick mentioned this pull request Apr 25, 2025
Merged
14 tasks
batrick added 3 commits April 25, 2025 15:11
@batrick
pybind/mgr/volumes: fix typo in casesensitive vxattr
63b95c3 
Fixes: https://tracker.ceph.com/issues/70974
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
qa: add test for cloning with charmap
358e6e8 
Fixes: https://tracker.ceph.com/issues/70974
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
pybind/mgr/volumes: make casesensitive attr uniform in interface
1fc9c44 
Fixes: https://tracker.ceph.com/issues/70996
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
@batrick
Copy link
Member Author

batrick commented Apr 26, 2025

jenkins test make check

1 similar comment
@batrick
Copy link
Member Author

batrick commented Apr 26, 2025

jenkins test make check

mchangir
mchangir reviewed Apr 29, 2025
View reviewed changes
mchangir
mchangir approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batrick batrick merged commit 86d08c2 into ceph:main Apr 29, 2025
12 checks passed
@batrick batrick deleted the i70996 branch April 29, 2025 16:52
@anoopcs9 anoopcs9 mentioned this pull request May 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchangir mchangir mchangir approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System documentation pybind tests wip-pdonnell-testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@batrick @xhernandez @mchangir