qa/workunits/fs/misc: remove data pool cleanup#62901
Merged
Conversation
This cleanup is at the very least incorrect as it can cause the MDS to throw read-only errors because the data pool is removed before it can write out backtraces. We've not yet finalized a truly safe workflow to remove a data pool -- even flushing the MDS journals first may not be enough (considering a large purge queue). Fixes: https://tracker.ceph.com/issues/70919 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
mchangir
reviewed
Apr 21, 2025
Comment on lines
-12
to
-13
| ceph fs rm_data_pool cephfs foo.$$ | ||
| ceph osd pool rm foo.$$ foo.$$ --yes-i-really-really-mean-it |
Contributor
There was a problem hiding this comment.
after flushing the journal, isn't there a way to check if the purge queue is empty to eventually decide on removing the data pool ?
Member
Author
There was a problem hiding this comment.
Sure, we could add a manual check to look at perf counters but how can we expect users/admins to do that? Until we have a proper interface, I don't see a point adding this to the tests.
Member
Author
|
jenkins test api |
Member
Author
|
jenkins test make check arm64 |
Member
Author
|
jenkins test api |
Member
Author
|
This PR is under test in https://tracker.ceph.com/issues/71000. |
Member
Author
|
jenkins test api |
Member
Author
|
jenkins test make check arm64 |
Member
Author
|
jenkins test make check arm64 |
This was referenced Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cleanup is at the very least incorrect as it can cause the MDS to throw read-only errors because the data pool is removed before it can write out backtraces.
We've not yet finalized a truly safe workflow to remove a data pool -- even flushing the MDS journals first may not be enough (considering a large purge queue).
Fixes: https://tracker.ceph.com/issues/70919
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition