osd: be more verbose in OSD::run_osd_bench_test#62866
Merged
Conversation
sseshasa
approved these changes
Apr 17, 2025
Contributor
sseshasa
left a comment
There was a problem hiding this comment.
LGTM apart from minor logging nits.
| } | ||
| } | ||
| dout(0) << __func__ | ||
| << " prefill took " << ceph_clock_now() - start |
Contributor
There was a problem hiding this comment.
Log with precision of 3 maybe?
Contributor
Author
There was a problem hiding this comment.
My plan is to leave it as visible as possible. Some tests run with debug_osd set to 0 and hence this info would be invisible with level = 3.
Given this is a seldom op I don't think it's a big deal to have it at level 0. Or am I missing anything?
Contributor
There was a problem hiding this comment.
@ifed01 I was not referring to the logging level. I am suggesting to use std::precision to truncate the decimal places for the duration to 3 places. Sorry for not being clearer.
Likely build-in OSD benchmarking is a source for bluestore slow ops in BlueStore at Teuthology runs. Let's have more logging for this procedure. Related-to: https://tracker.ceph.com/issues/68337 Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
9b30af8 to
970b079
Compare
Contributor
|
Rados Approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Likely build-in OSD benchmarking is a source for bluestore slow ops in BlueStore at Teuthology runs.
Let's have more logging for this procedure.
Related-to: https://tracker.ceph.com/issues/68337
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition