mds: use available CInode* for uninline data#62684
Merged
Conversation
dbcb9db to
2845109
Compare
14 tasks
vshankar
reviewed
Apr 9, 2025
2845109 to
0f67a35
Compare
vshankar
approved these changes
Apr 10, 2025
Contributor
|
This PR is under test in https://tracker.ceph.com/issues/70893. |
vshankar
approved these changes
Apr 22, 2025
Contributor
|
jenkins retest this please |
1 similar comment
Contributor
|
jenkins retest this please |
Contributor
|
jenkins test make check |
Contributor
|
jenkins retest this please |
2 similar comments
Contributor
|
jenkins retest this please |
Contributor
|
jenkins retest this please |
Contributor
|
jenkins test docs |
3 similar comments
Contributor
|
jenkins test docs |
Contributor
|
jenkins test docs |
Contributor
|
jenkins test docs |
Contributor
|
Has "jenkins test docs" stopped auto-running the docs jenkins test? |
Contributor
|
jenkins test docs |
Contributor
|
@mchangir mind pushing a rebase please? I cannot get the docs test to even run for retesting. |
This is a null pointer dereference issue and it happens as follows: Uninline Data is not a regular client request ... it is an Internal Request. So, there's no client request struct allocated and assigned in the mdr to begin with. In the scrubbing path, the auth validation is already done in ScrubStack::kick_off_scrubs() ... and since Uninline Data path piggybacks on the scrubbing path, we get the auth validation for free. rdlock_path_pin_ref(), fails to lock the path if the lock is already taken. This is what happens in the Uninline Data case. So rdlock_path_pin_ref() creates a C_MDS_RetryRequest and this causes the request to be re-attempted in the regular client request path where Server::handle_client_request() assumes that the mdr->client_request member is valid ... and hence the null pointer dereference issue. --- Since the scrub path dequeues the CInode* from the ScrubStack, this commit attempts to use the already available CInode*. Fixes: https://tracker.ceph.com/issues/70624 Signed-off-by: Milind Changire <mchangir@redhat.com>
0f67a35 to
0ea8570
Compare
Contributor
Author
|
trivial rebase |
Contributor
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: https://tracker.ceph.com/issues/70624
Signed-off-by: Milind Changire mchangir@redhat.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition