Skip to content

mon: Fix cast warning#62674

Merged
vshankar merged 1 commit intoceph:mainfrom
adamemerson:wip-mon-signed-comparison
Apr 22, 2025
Merged

mon: Fix cast warning#62674
vshankar merged 1 commit intoceph:mainfrom
adamemerson:wip-mon-signed-comparison

Conversation

@adamemerson
Copy link
Contributor

@adamemerson adamemerson commented Apr 3, 2025

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

Signed-off-by: Adam Emerson <aemerson@redhat.com>
@adamemerson adamemerson requested a review from batrick April 3, 2025 22:36
@adamemerson adamemerson requested a review from a team as a code owner April 3, 2025 22:36
@github-actions github-actions bot added cephfs Ceph File System core mon labels Apr 3, 2025
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tchaikov
Copy link
Contributor

tchaikov commented Apr 4, 2025

jenkins test make check arm64

@ronen-fr
Copy link
Contributor

ronen-fr commented Apr 4, 2025

maybe cmd_getval_cast_or() can be extended?

@adamemerson
Copy link
Contributor Author

@ljflores Could you pull this in for core testing, please?

@vshankar
Copy link
Contributor

This PR is under test in https://tracker.ceph.com/issues/70893.

Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vshankar vshankar merged commit 4899b2c into ceph:main Apr 22, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants