Skip to content

test/crimson/test_crimson_coroutines: showcase errorator examples#62649

Merged
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-crimson-coroutines-errors
Apr 7, 2025
Merged

test/crimson/test_crimson_coroutines: showcase errorator examples#62649
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-crimson-coroutines-errors

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Apr 3, 2025

This came up in #62530 (#62530 (comment)).
Showcase an awaited throwing coroutine and a passed_further error.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@Matan-B Matan-B requested a review from a team as a code owner April 3, 2025 09:08
@Matan-B Matan-B requested a review from cyx1231st April 3, 2025 09:09
@Matan-B Matan-B added this to Crimson Apr 3, 2025
@Matan-B Matan-B moved this to Awaits review in Crimson Apr 3, 2025
Copy link
Member

@cyx1231st cyx1231st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great examples!

This came up in ceph#62530.
Showcase an awaited throwing coroutine and a passed_further error.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-coroutines-errors branch from 188143b to 34b7ca1 Compare April 3, 2025 11:34
@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

jenkins test make check

@Matan-B Matan-B moved this from Awaits review to Merged in Crimson Apr 7, 2025
@Matan-B Matan-B merged commit 44ad32a into ceph:main Apr 7, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged (Pre Tentacle Freeze)

Development

Successfully merging this pull request may close these issues.

3 participants