Skip to content

mgr/vol: some improvements for stats_util.py and async_cloner.py#62638

Merged
rishabh-d-dave merged 3 commits intoceph:mainfrom
rishabh-d-dave:vols-path-gone-missing
May 5, 2025
Merged

mgr/vol: some improvements for stats_util.py and async_cloner.py#62638
rishabh-d-dave merged 3 commits intoceph:mainfrom
rishabh-d-dave:vols-path-gone-missing

Conversation

@rishabh-d-dave
Copy link
Contributor

@rishabh-d-dave rishabh-d-dave commented Apr 2, 2025 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/71019

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@rishabh-d-dave rishabh-d-dave requested a review from a team April 2, 2025 18:33
@github-actions github-actions bot added the pybind label Apr 2, 2025
@rishabh-d-dave rishabh-d-dave changed the title mgr/vol: some improvements for stats_util and async_cloner.py mgr/vol: some improvements for stats_util.py and async_cloner.py Apr 2, 2025
@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch from 86f7f9a to 14ad428 Compare April 22, 2025 15:25
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 22, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 22, 2025

jenkins test api

@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch 2 times, most recently from 1829020 to cfa8d79 Compare April 22, 2025 15:37
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 22, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 22, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 22, 2025

This PR is under test in https://tracker.ceph.com/issues/71020.

@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch from cfa8d79 to be06e1e Compare April 22, 2025 18:00
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 23, 2025

jenkins test make check

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 23, 2025

jenkins test make check arm64

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 23, 2025

jenkins test api

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented Apr 24, 2025

jenkins test make check

mchangir
mchangir requested changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small corrections

@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch from be06e1e to de4163d Compare April 24, 2025 12:38
@rishabh-d-dave
mgr/vol: for "clone status" handle case where path goes missing
ad38967 
If source and/or destination path of the cloning operation goes missing
during it's ongoing or just before it becomes ongoing, "ceph fs clone
status" command can fail. Account for and handle such cases gracefully.

Fixes: https://tracker.ceph.com/issues/71019
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch 2 times, most recently from 96c924b to 21cb007 Compare April 25, 2025 10:38
mchangir
mchangir approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@mchangir mchangir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabh-d-dave
mgr/vol: handle case where path goes missing for a clone
359277b 
A thread is spawned to get the value of a certain extended attribute to
generate the progress statistics for the ongoing clone operations. In
case source and/or destination path for a clone operation goes missing,
this thread crashes. Instead of crashing, handle this case gracefully.

Fixes: https://tracker.ceph.com/issues/71019
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave
mgr/vol: log in case path goes in missing in async_cloner.py
278293b 
Add a log entry in case the source and/or destination path goes missing
for a clone operation.

Fixes: https://tracker.ceph.com/issues/71019
Signed-off-by: Rishabh Dave <ridave@redhat.com>
@rishabh-d-dave rishabh-d-dave force-pushed the vols-path-gone-missing branch from 21cb007 to 278293b Compare May 4, 2025 13:32
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 4, 2025

jenkins test windows

@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 5, 2025

jenkins test make check arm64

rishabh-d-dave
rishabh-d-dave commented May 5, 2025
View reviewed changes
Copy link
Contributor Author

@rishabh-d-dave rishabh-d-dave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full QA run[1] had some related failures. But those were fixed[2] and failed jobs began passing then[3][4][5].

[1] https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-rishabh-testing-20250426123842-debug
[2] https://github.com/ceph/ceph/compare/21cb0070dd6358ace39050f74365d6ffa7a8dc95..278293b3389a2a48da4fbb27a5dfd8a7c6a63ae1
[3] https://pulpito.ceph.com/rishabh-2025-05-04_15:33:00-fs:volumes-rishabh-vols-path-gone-missing-testing-default-smithi/
[4] https://pulpito.ceph.com/rishabh-2025-05-04_19:45:54-fs:volumes-rishabh-vols-path-gone-missing-testing-default-smithi/
[5] https://pulpito.ceph.com/rishabh-2025-05-05_07:34:19-fs:volumes-rishabh-vols-path-gone-missing-testing-default-smithi/

@rishabh-d-dave rishabh-d-dave added the passed-qa for PRs that have passed QA but there's an on-going conversation, so merging would be premature label May 5, 2025
@rishabh-d-dave
Copy link
Contributor Author

rishabh-d-dave commented May 5, 2025

Waiting for this CI to pass now.

@rishabh-d-dave rishabh-d-dave merged commit 1224fd4 into ceph:main May 5, 2025
12 checks passed
@rishabh-d-dave rishabh-d-dave deleted the vols-path-gone-missing branch May 5, 2025 11:39
@rishabh-d-dave rishabh-d-dave mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchangir mchangir mchangir approved these changes

Assignees

No one assigned

Labels

cephfs Ceph File System needs-review passed-qa for PRs that have passed QA but there's an on-going conversation, so merging would be premature pybind wip-rishabh-testing2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rishabh-d-dave @mchangir