Skip to content

test/crimson/test_errorator: showcase assert_all/handle/pass_furhter#62635

Merged
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-crimson-ignore-abort
Apr 8, 2025
Merged

test/crimson/test_errorator: showcase assert_all/handle/pass_furhter#62635
Matan-B merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-crimson-ignore-abort

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Apr 2, 2025

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@Matan-B Matan-B requested review from athanatos and jdurgin April 2, 2025 16:30
@Matan-B Matan-B requested a review from a team as a code owner April 2, 2025 16:30
@Matan-B Matan-B force-pushed the wip-matanb-crimson-ignore-abort branch 2 times, most recently from 13683cc to 3f70d4c Compare April 2, 2025 16:35
Copy link
Member

@cyx1231st cyx1231st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment-out tests behave (abort) expectedly ?

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

Does the comment-out tests behave (abort) expectedly ?

Yes. Kept them commented out since it could be useful if one wants to reproduce these aborts locally.

@Matan-B Matan-B added this to Crimson Apr 3, 2025
@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 3, 2025

jenkins test api

@Matan-B Matan-B moved this to Awaits review in Crimson Apr 3, 2025
@Matan-B Matan-B force-pushed the wip-matanb-crimson-ignore-abort branch from 3f70d4c to d0868e4 Compare April 7, 2025 09:43
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-ignore-abort branch from d0868e4 to 396674f Compare April 7, 2025 09:47
@Matan-B Matan-B changed the title test/crimson/test_errorator: showcase ignore assert_all test/crimson/test_errorator: showcase assert_all/handle/pass_furhter Apr 7, 2025
@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 7, 2025

Does the comment-out tests behave (abort) expectedly ?

I'm moving the abort section to #62699, we seem to have an issue there which I'll handle separately. For now, I'll merge the other examples here.

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 7, 2025

jenkins test make check

@Matan-B Matan-B merged commit 1f4a05c into ceph:main Apr 8, 2025
12 of 19 checks passed
@Matan-B Matan-B moved this from Awaits review to Merged in Crimson Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged (Pre Tentacle Freeze)

Development

Successfully merging this pull request may close these issues.

3 participants