cephfs: session tracker accounts for killing sessions#62631
cephfs: session tracker accounts for killing sessions#62631
Conversation
|
An alternative is just to return in case sessions != 0 instead of asserting, not sure whether we can reach a state where the lone session is in a SESSION_OPENING state also |
|
@mchangir PTAL |
|
jenkins test make check |
I have encountered this case, the session is opening. I think this case needs to be covered as well. |
|
@vshankar should I add the |
Fair enough. Please handle that case too. |
Fixes: https://tracker.ceph.com/issues/70770 Signed-off-by: Abhishek Lekshmanan <abhishek.lekshmanan@cern.ch>
e4d0dc4 to
bb52cb7
Compare
Done |
|
This PR is under test in https://tracker.ceph.com/issues/71260. |
Suite run looks good. This will be merged soon. |
Fixes: https://tracker.ceph.com/issues/70770
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition