Conversation
|
full crimson run, single failure unrelated: https://pulpito.ceph.com/sjust-2025-04-01_22:36:20-crimson-rados-wip-sjust-crimson-testing-pct-2025-04-01-1743532638-distro-default-gibba/ |
|
"osd/pg_features: advertise PG_FEATURE_PCT for crimson" does modify a file in osd/, but only to update a constant used only in crimson. I don't feel that this requires a classic run. |
e346fa6 to
bc452b3
Compare
|
The pool pct_update_delay option should already default to 5 in the rados task, it was just ignored before. |
|
jenkins test make check |
|
jenkins test make check arm64 |
|
jenkins test make check |
|
jenkins test make check arm64 |
bc452b3 to
bfc72f7
Compare
|
jenkins test api |
src/crimson/common/intrusive_timer.h
Outdated
| * schedule/cancel | ||
| */ | ||
| class intrusive_timer_t { | ||
| using clock_t = ceph::coarse_real_clock; |
There was a problem hiding this comment.
Is it better to use seastar native seastar::lowres_system_clock ?
There was a problem hiding this comment.
Why can't we use seastar::timer<seastar::lowres_clock> instead? It allows canceling and rearming a callback, are there any other advantages to intrusive_timer_t which I'm missing?
There was a problem hiding this comment.
Nope, that works perfectly -- I just missed it. I've repushed with seastar::timer and am running another test set.
src/crimson/common/intrusive_timer.h
Outdated
| * schedule/cancel | ||
| */ | ||
| class intrusive_timer_t { | ||
| using clock_t = ceph::coarse_real_clock; |
There was a problem hiding this comment.
Why can't we use seastar::timer<seastar::lowres_clock> instead? It allows canceling and rearming a callback, are there any other advantages to intrusive_timer_t which I'm missing?
bfc72f7 to
1df6b82
Compare
|
Repushed using seastar::timer as @Matan-B suggests, retesting. |
|
jenkins test make check arm64 |
|
jenkins test make check arm64 |
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Samuel Just <sjust@redhat.com>
1df6b82 to
666cafc
Compare
|
2/51 failures:
|
|
jenkins test api |
8250534 seems like a duplicate of the backfill stuck issue - IIUC the backfill fixes were part of this run as well? |
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition