Skip to content

mgr/dashboard: introduce dashboard setting to resolve rgw hostname#62596

Merged
afreen23 merged 1 commit intoceph:mainfrom
rhcs-dashboard:rgw-url
Apr 7, 2025
Merged

mgr/dashboard: introduce dashboard setting to resolve rgw hostname#62596
afreen23 merged 1 commit intoceph:mainfrom
rhcs-dashboard:rgw-url

Conversation

@nizamial09
Copy link
Member

@nizamial09 nizamial09 commented Apr 1, 2025

drops using the rgw_dns_name to resolve the rgw hosts in dashboard and
introduces a command ceph dashboard set-rgw-hostname <daemon> <hostname> to set custom dns names for each gateways. Once set
dashboard will pick up that address for the selected gateway.

And a config can be unset by

ceph dashboard unset-rgw-hostname <daemon>

Fixes: https://tracker.ceph.com/issues/70744

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

ceph dashboard set-rgw-api-ssl-verify False

If you want to set a custom hostname or IP to resolve the rgw endpoint, you can
use the RGW_HOSTNAME setting to do it.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To set a custom hostname or address for an RGW endpoint, set the value of RGW_HOSTNAME accordingly:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thank you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, made a few more changes according to the recent modification but they are minor updates. PTAL, thanks

drops using the `rgw_dns_name` to resolve the rgw hosts in dashboard and
introduces a command `ceph dashboard set-rgw-hostname <daemon>
<hostname>` to set custom dns names for each gateways. Once set
dashboard will pick up that address for the selected gateway.

And a config can be unset by

`ceph dashboard unset-rgw-hostname <daemon>`

Fixes: https://tracker.ceph.com/issues/70744
Signed-off-by: Nizamudeen A <nia@redhat.com>
@nizamial09
Copy link
Member Author

jenkins test api

@nizamial09
Copy link
Member Author

jenkins test make check

@nizamial09
Copy link
Member Author

jenkins test make check arm64

Copy link
Contributor

@aaSharma14 aaSharma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works fine.

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Apr 3, 2025
@aaSharma14
Copy link
Contributor

jenkins test make check

@aaSharma14
Copy link
Contributor

jenkins test make check arm64

@aaSharma14
Copy link
Contributor

jenkins test make check

2 similar comments
@aaSharma14
Copy link
Contributor

jenkins test make check

@aaSharma14
Copy link
Contributor

jenkins test make check

@cloudbehl
Copy link
Contributor

jenkins test make check

@afreen23 afreen23 merged commit 9aacbd1 into ceph:main Apr 7, 2025
15 checks passed
@afreen23 afreen23 deleted the rgw-url branch April 7, 2025 11:12
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants