Skip to content

fmt: bump up version to 11.1.4#62568

Merged
tchaikov merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-fmt-11.1.4
Jun 19, 2025
Merged

fmt: bump up version to 11.1.4#62568
tchaikov merged 1 commit intoceph:mainfrom
Matan-B:wip-matanb-fmt-11.1.4

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Mar 30, 2025 •
edited
Loading

Move fmt submodule branch (from wip-fmt-11.0.2) to
https://github.com/ceph/fmt/releases/tag/11.1.4

Following system's fmt support update: #62564

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@Matan-B Matan-B requested review from ronen-fr and tchaikov March 30, 2025 08:26
@Matan-B Matan-B mentioned this pull request Mar 30, 2025
Merged
14 tasks
@tchaikov
Copy link
Contributor

tchaikov commented Mar 30, 2025

@Matan-B hi Matan, could you please use a better name than "wip-matanb-fmt-11.1.4" , specifically without a wip or user name in it, so the branch won't be nuked by accident? ideally, we can just sync ceph/fmt 's master branch with upstream, as the tag of "11.1.4" was tagged on master, see fmtlib/fmt@1239137

@Matan-B
fmt: bump up version to 11.1.4
a732b48 
Move fmt submodule branch to
https://github.com/ceph/fmt/releases/tag/11.1.4

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-fmt-11.1.4 branch from f54004c to a732b48 Compare March 30, 2025 08:54
@Matan-B
Copy link
Contributor Author

Matan-B commented Mar 30, 2025 •
edited
Loading

@Matan-B hi Matan, could you please use a better name than "wip-matanb-fmt-11.1.4" , specifically without a wip or user name in it, so the branch won't be nuked by accident? ideally, we can just sync ceph/fmt 's master branch with upstream, as the tag of "11.1.4" was tagged on master, see fmtlib/fmt@1239137

@tchaikov, submodule is now update to use https://github.com/ceph/fmt/releases/tag/11.1.4 instead.
I've removed wip-matanb-fmt-11.1.4.

tchaikov
tchaikov approved these changes Mar 30, 2025
View reviewed changes
Copy link
Contributor

@tchaikov tchaikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. FWIW, fmtlib's latest stable release is 11.1.4.

we should be able to merge this change once the CI is green -- it's pending on #62567

ronen-fr
ronen-fr approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@ronen-fr ronen-fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW - I though updating a sub-module should be seen (in the PR) as a change to
the git refs in ceph/src?

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 1, 2025

BTW - I though updating a sub-module should be seen (in the PR) as a change to the git refs in ceph/src?

I'm not sure I understand the question, updating a sub-module moves the "Subproject commit" (used by the parent project) to a different HEAD, in this case we moved to the same commit as used by https://github.com/ceph/fmt/releases/tag/11.1.4.

@ronen-fr
Copy link
Contributor

ronen-fr commented Apr 1, 2025

I'm not sure I understand the question, updating a sub-module moves the "Subproject commit" (used by the parent project) to a different HEAD

I was wondering why the "files changed" above shows a "Submodule fmt updated [56 files]". OK - now I see. I though the "56 files" is part of the sentence.

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 1, 2025

jenkins retest this please

@Matan-B
Copy link
Contributor Author

Matan-B commented Apr 1, 2025 

-- Linking to fmt library.
-- Building fmt as submodule
-- {fmt} version: 11.1.4
-- Build type: Debug

@kamoltat
Copy link
Member

kamoltat commented Jun 19, 2025

RADOS APPROVED: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues71466

@tchaikov tchaikov mentioned this pull request Jun 19, 2025
Closed
14 tasks
@tchaikov tchaikov merged commit 18c9857 into ceph:main Jun 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaikov tchaikov tchaikov approved these changes

@ronen-fr ronen-fr ronen-fr approved these changes

Assignees

No one assigned

Labels

needs-qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Matan-B @tchaikov @ronen-fr @kamoltat @SrinivasaBharath