client: fix unmount hang after lookups by dparmar18 · Pull Request #62488 · ceph/ceph

dparmar18 · 2025-03-25T11:20:26Z

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins test classic perf Jenkins Job | Jenkins Job Definition
jenkins test crimson perf Jenkins Job | Jenkins Job Definition
jenkins test signed Jenkins Job | Jenkins Job Definition
jenkins test make check Jenkins Job | Jenkins Job Definition
jenkins test make check arm64 Jenkins Job | Jenkins Job Definition
jenkins test submodules Jenkins Job | Jenkins Job Definition
jenkins test dashboard Jenkins Job | Jenkins Job Definition
jenkins test dashboard cephadm Jenkins Job | Jenkins Job Definition
jenkins test api Jenkins Job | Jenkins Job Definition
jenkins test docs ReadTheDocs | Github Workflow Definition
jenkins test ceph-volume all Jenkins Jobs | Jenkins Jobs Definition
jenkins test windows Jenkins Job | Jenkins Job Definition
jenkins test rook e2e Jenkins Job | Jenkins Job Definition

dparmar18 · 2025-04-08T13:58:13Z

Locally:

[       OK ] LibCephFS.OpenatFilePathUnmountCheck (149 ms)
[----------] 100 tests from LibCephFS (103914 ms total)

[----------] Global test environment tear-down
[==========] 100 tests from 1 test suite ran. (103914 ms total)
[  PASSED  ] 100 tests.

src/client/Client.cc

dparmar18 · 2025-04-10T20:03:06Z

jenkins test make check

src/client/Client.cc

vshankar

minor nits. otherwise lgtm.

src/test/libcephfs/test.cc

dparmar18 · 2025-05-13T11:35:15Z

jenkins retest this please

dparmar18 · 2025-05-13T11:35:29Z

@batrick @vshankar RFR

dparmar18 · 2025-05-13T12:36:36Z

jenkins test make check arm64

vshankar

Otherwise LGTM.

src/test/libcephfs/test.cc

dparmar18 · 2025-05-29T07:34:28Z

last push: rebased + fixed conflict

github-actions · 2025-06-20T08:59:26Z

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

vshankar · 2025-06-20T09:13:11Z

@dparmar18 please rebase. will put this to test next.

Fixes: https://tracker.ceph.com/issues/70553 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

adds an extra ref to the root which leads to ref leaks: 2025-03-26T15:37:55.162+0530 7fadb8d41640 1 client.4293 dump_inode: DISCONNECTED inode 0x1 #0x1 ref 2 0x1.head(faked_ino=0 nref=2 ll_ref=0 cap_refs={1024=0} open={} mode=41777 size=0/0 nlink=1 btime=2025-03-26T15:37:39.967146+0530 mtime=2025-03-26T15:37:45.113229+0530 ctime=2025-03-26T15:37:45.136266+0530 change_attr=3 caps=pAsLsXs(0=pAsLsXs) COMPLETE has_dir_layout 0x7fad78006970) which leads to: 2025-03-26T15:37:55.162+0530 7fadb8d41640 2 client.4293 cache still has 1+1 items, waiting (for caps to release?) Fixes: https://tracker.ceph.com/issues/70553 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

Lookup on non-dir inode is incorrect. Client::_lookup did check for it but the order needed to be correct i.e. check for non-dir inode before anything. Fixes: https://tracker.ceph.com/issues/70553 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

dparmar18 · 2025-06-20T09:49:28Z

@dparmar18 please rebase. will put this to test next.

rebased @vshankar

vshankar · 2025-07-22T17:02:31Z

This PR is under test in https://tracker.ceph.com/issues/72244.

vshankar

https://tracker.ceph.com/projects/cephfs/wiki/QA_main_2025#wip-vshankar-testing-20250730064735-debug

vshankar · 2025-08-05T11:23:29Z

@batrick @tchaikov - do you have another more comments on this change?

Seems like there isn't any objection to this change.

github-actions bot added cephfs Ceph File System tests labels Mar 25, 2025

dparmar18 force-pushed the i70553 branch 2 times, most recently from 674cf93 to ca6a145 Compare March 27, 2025 11:52

dparmar18 mentioned this pull request Mar 27, 2025

libcephfs_proxy: workaround for delays and hangs in the proxy #62483

Merged

14 tasks

dparmar18 changed the title ~~[DO NOT REVIEW] client: fix unmount hang after lookups~~ client: fix unmount hang after lookups Apr 8, 2025

dparmar18 marked this pull request as ready for review April 8, 2025 13:57

dparmar18 force-pushed the i70553 branch 3 times, most recently from 74da2cd to 9d4559f Compare April 8, 2025 23:37

dparmar18 requested review from a team and vshankar April 8, 2025 23:38

vshankar reviewed Apr 10, 2025

View reviewed changes

src/client/Client.cc Outdated Show resolved Hide resolved

vshankar requested a review from batrick April 23, 2025 12:31

dparmar18 added the needs-review label Apr 23, 2025

batrick reviewed Apr 23, 2025

View reviewed changes

src/client/Client.cc Show resolved Hide resolved

batrick previously requested changes Apr 23, 2025

View reviewed changes

src/client/Client.cc Outdated Show resolved Hide resolved

dparmar18 force-pushed the i70553 branch from 9d4559f to 610d75e Compare April 24, 2025 10:03

dparmar18 requested review from batrick and vshankar April 24, 2025 10:04

vshankar reviewed Apr 24, 2025

View reviewed changes

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

dparmar18 force-pushed the i70553 branch from 610d75e to feee296 Compare May 8, 2025 08:28

dparmar18 requested a review from vshankar May 13, 2025 11:35

vshankar requested changes May 13, 2025

View reviewed changes

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

src/test/libcephfs/test.cc Outdated Show resolved Hide resolved

dparmar18 force-pushed the i70553 branch from feee296 to ce246c4 Compare May 14, 2025 10:06

dparmar18 force-pushed the i70553 branch from fcffaa7 to 7616eeb Compare May 29, 2025 07:33

github-actions bot removed the needs-rebase label May 29, 2025

vshankar added wip-vshankar-testing1 and removed wip-vshankar-testing labels May 29, 2025

github-actions bot added the needs-rebase label Jun 20, 2025

dparmar18 added 3 commits June 20, 2025 15:18

qa: test unmount hang using high/low level APIs

cbf1c5b

Fixes: https://tracker.ceph.com/issues/70553 Signed-off-by: Dhairya Parmar <dparmar@redhat.com>

dparmar18 force-pushed the i70553 branch from 7616eeb to aa6ffa5 Compare June 20, 2025 09:49

github-actions bot removed the needs-rebase label Jun 20, 2025

vshankar added wip-vshankar-testing wip-vshankar-testing1 and removed wip-vshankar-testing1 wip-vshankar-testing labels Jun 24, 2025

vshankar added wip-vshankar-testing3 and removed wip-vshankar-testing1 labels Jul 22, 2025

vshankar approved these changes Aug 4, 2025

View reviewed changes

vshankar merged commit 416c794 into ceph:main Aug 11, 2025
13 checks passed

vshankar removed the wip-vshankar-testing3 label Aug 11, 2025

joscollin mentioned this pull request Aug 27, 2025

tentacle: client: fix unmount hang after lookups #65254

Merged

This was referenced Aug 28, 2025

squid: client: fix unmount hang after lookups #65289

Merged

tentacle: client: fix unmount hang after lookups #65290

Closed

Conversation

dparmar18 commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

dparmar18 commented Apr 8, 2025

Uh oh!

Uh oh!

dparmar18 commented Apr 10, 2025

Uh oh!

Uh oh!

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dparmar18 commented May 13, 2025

Uh oh!

dparmar18 commented May 13, 2025

Uh oh!

dparmar18 commented May 13, 2025

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dparmar18 commented May 29, 2025

Uh oh!

github-actions bot commented Jun 20, 2025

Uh oh!

vshankar commented Jun 20, 2025

Uh oh!

dparmar18 commented Jun 20, 2025

Uh oh!

vshankar commented Jul 22, 2025

Uh oh!

vshankar left a comment

Choose a reason for hiding this comment

Uh oh!

vshankar commented Aug 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dparmar18 commented Mar 25, 2025 •

edited

Loading