squid: rgw/async/notifications: use common async waiter in pubsub push#62337
Merged
yuriw merged 3 commits intoceph:squidfrom Apr 24, 2025
Merged
squid: rgw/async/notifications: use common async waiter in pubsub push#62337yuriw merged 3 commits intoceph:squidfrom
yuriw merged 3 commits intoceph:squidfrom
Conversation
Contributor
|
jenkins test api |
Contributor
|
jenkins test make check |
Contributor
Author
|
jenkins test api |
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Contributor
Author
will rebase |
Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit dd779c7)
* use the "yield_waiter" and "waiter" from common/async insteasd of the "waiter" implemented inside the bucket notification code (this is so we don't need separate investigations for 2 implementations) * added a unit test that simulate how a separate thread (kafka or amqp) is resuming a coroutine which is created by either the frontend or the notification manager. before using "defer" the unit test is passing, however, when executed under thread sanitizer (using the WITH_TSAN cmake flag) the following errors are observed: https://0x0.st/Xp4P.txt after using "defer" the unit test passes under TSAN without errors. Fixes: https://tracker.ceph.com/issues/64184 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com> (cherry picked from commit 2872c75)
In file included from src/rgw/driver/posix/bucket_cache.h:19,
from src/test/rgw/test_posix_bucket_cache.cc:4:
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::lock()_:
src/common/cohort_lru.h:334:14: error: _for_each_ is not a member of _std_
334 | std::for_each(locks.begin(), locks.end(),
| ^~~~~~~~
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::unlock()_:
/home/yuvalif/ceph5/src/common/cohort_lru.h:339:14: error: _for_each_ is not a member of _std_
339 | std::for_each(locks.begin(), locks.end(),
| ^~~~~~~~
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
dc84164 to
b578675
Compare
Contributor
|
jenkins test make check |
Contributor
|
jenkins test api |
adamemerson
approved these changes
Apr 24, 2025
Contributor
|
jenkins test make check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/67309
backport of #58765
parent tracker: https://tracker.ceph.com/issues/64184
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh