Skip to content

mgr/dashboard: Revert PR 61089#62103

Merged
epuertat merged 3 commits intoceph:mainfrom
rhcs-dashboard:revert-pr-61089
Mar 4, 2025
Merged

mgr/dashboard: Revert PR 61089#62103
epuertat merged 3 commits intoceph:mainfrom
rhcs-dashboard:revert-pr-61089

Conversation

@nizamial09
Copy link
Copy Markdown
Member

@nizamial09 nizamial09 commented Mar 4, 2025

Revert of #61089
Reverting it so we can focus on the improved implementation on #61967

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands

@nizamial09
Copy link
Copy Markdown
Member Author

@nizamial09 nizamial09 requested a review from epuertat March 4, 2025 14:33
…_FRONTEND)."

This reverts commit 37e6333.

Signed-off-by: Nizamudeen A <nia@redhat.com>
…vices/proto using the protobuf file from the gateway submodule."

This reverts commit 7f2e191.

Signed-off-by: Nizamudeen A <nia@redhat.com>
This reverts commit 0ff89b0.

Signed-off-by: Nizamudeen A <nia@redhat.com>
@pecastro
Copy link
Copy Markdown
Contributor

pecastro commented Mar 4, 2025

Looks legit.

@github-project-automation github-project-automation bot moved this from New to Reviewer approved in Ceph-Dashboard Mar 4, 2025
@epuertat epuertat merged commit db11602 into ceph:main Mar 4, 2025
11 of 13 checks passed
@epuertat epuertat deleted the revert-pr-61089 branch March 4, 2025 19:10
@github-project-automation github-project-automation bot moved this from Reviewer approved to Done in Ceph-Dashboard Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants