rgw: use object ARN for InitMultipart permissions#62020
Merged
adamemerson merged 1 commit intoceph:mainfrom Mar 5, 2025
Merged
rgw: use object ARN for InitMultipart permissions#62020adamemerson merged 1 commit intoceph:mainfrom
adamemerson merged 1 commit intoceph:mainfrom
Conversation
from https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html#mpuAndPermissions: > You must be allowed to perform the s3:PutObject action on an object to create a multipart upload request. but it was calling the verify_bucket_permission() overload which defaulted to the bucket ARN. pass the object ARN instead, like we do for RGWPutObj and RGWCompleteMultipart Fixes: https://tracker.ceph.com/issues/70191 Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
test case in ceph/s3-tests#625 |
Contributor
Author
|
i was concerned that this change might break existing policies that only granted permission on the bucket ARN, but such policies would reject UploadPart and CompleteMultipartUpload requests so would be broken regardless |
ivancich
approved these changes
Feb 27, 2025
Contributor
Author
|
passed qa against ceph/s3-tests#625 in https://pulpito.ceph.com/cbodley-2025-02-28_00:54:32-rgw-wip-70191-distro-default-smithi/
|
Contributor
Author
|
jenkins test windows |
Contributor
Author
|
jenkins test make check arm64 |
1 similar comment
Contributor
Author
|
jenkins test make check arm64 |
Contributor
Author
|
https://jenkins.ceph.com/job/ceph-pull-requests-arm64/69457/
|
Contributor
Author
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from https://docs.aws.amazon.com/AmazonS3/latest/userguide/mpuoverview.html#mpuAndPermissions:
but it was calling the verify_bucket_permission() overload which defaulted to the bucket ARN. pass the object ARN instead, like we do for RGWPutObj and RGWCompleteMultipart
Fixes: https://tracker.ceph.com/issues/70191
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e