pybind/mgr/dashboard: prevent installing grpc-tools every time when running ninja#61954
Closed
pybind/mgr/dashboard: prevent installing grpc-tools every time when running ninja#61954
Conversation
…unning ninja Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Member
Author
|
jenkins test make check |
Member
epuertat
reviewed
Mar 4, 2025
Comment on lines
+4
to
+6
| set(GRPC_TOOLS_DIR ${CEPH_GRPC_VIRTUALENV}/lib/python${Python3_VERSION_MAJOR}.${Python3_VERSION_MINOR}/site-packages/grpc_tools) | ||
|
|
||
| message(STATUS "install grpc-tools into ${GRPC_TOOLS_DIR}") |
Member
There was a problem hiding this comment.
The truth is that we don't even need to handle this (CC: @pecastro). The installation of grpc* stuff should be done via BuildRequires/Debian-equivalent. And this tool is invoked through python3 -m grpcio_tools.protoc, so same thing.
14 tasks
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
Member
Author
|
It seems that a better solution is underway, so I will close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems the globstar matching symbol causes it to always be executed when running Ninja. Let's set it explicitly.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e