Skip to content

cephfs_mirror: add --sync-latest-snapshot and --sync_from_snapshot options#61929

Open
joscollin wants to merge 3 commits intoceph:mainfrom
joscollin:wip-F69187-sync-from-snapshot
Open

cephfs_mirror: add --sync-latest-snapshot and --sync_from_snapshot options#61929
joscollin wants to merge 3 commits intoceph:mainfrom
joscollin:wip-F69187-sync-from-snapshot

Conversation

@joscollin
Copy link
Member

@joscollin joscollin commented Feb 20, 2025 •
edited
Loading

Fixes: https://tracker.ceph.com/issues/69187
Fixes: https://tracker.ceph.com/issues/69188
Fixes: https://tracker.ceph.com/issues/69966

Introduces --sync-latest-snapshot and --sync_from_snapshot options.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@joscollin joscollin requested a review from a team as a code owner February 20, 2025 06:19
@joscollin joscollin marked this pull request as draft February 20, 2025 06:20
@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch from 134497e to f080c98 Compare February 21, 2025 04:58
@joscollin
Copy link
Member Author

joscollin commented Feb 21, 2025

https://pulpito.ceph.com/jcollin-2025-02-21_02:08:35-fs:mirror-wip-jcollin-testing-20022025-distro-default-smithi/

@joscollin joscollin marked this pull request as ready for review February 21, 2025 04:59
@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch from f080c98 to 1464f88 Compare February 25, 2025 06:29
@joscollin joscollin requested a review from a team February 25, 2025 06:29
@joscollin joscollin marked this pull request as draft March 4, 2025 04:22
@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch 4 times, most recently from d88e88f to e4816c7 Compare March 5, 2025 10:02
@joscollin joscollin changed the title cephfs_mirror: add sync_from_snapshot option cephfs_mirror: add sync_from_snapshot, --sync-latest-snapshot options Mar 5, 2025
@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch 6 times, most recently from f772a6d to cac2b1c Compare March 7, 2025 05:25
@joscollin joscollin changed the title cephfs_mirror: add sync_from_snapshot, --sync-latest-snapshot options cephfs_mirror: add --sync_from_snapshot, --sync-latest-snapshot options Mar 10, 2025
@joscollin
Copy link
Member Author

joscollin commented Mar 10, 2025

https://pulpito.ceph.com/jcollin-2025-03-10_02:58:48-fs:mirror-wip-jcollin-testing-07032025-2-distro-default-smithi/
Tests passed for --sync_from_snapshot and --sync-latest-snapshot.

@joscollin joscollin marked this pull request as ready for review March 10, 2025 07:08
@vshankar
Copy link
Contributor

vshankar commented Oct 9, 2025

We would want to have this functionality for Umbrella release.

@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch from b782090 to 119320c Compare October 21, 2025 09:21
vshankar
vshankar reviewed Dec 5, 2025
View reviewed changes
vshankar
vshankar reviewed Dec 5, 2025
View reviewed changes
vshankar
vshankar reviewed Dec 5, 2025
View reviewed changes
vshankar
vshankar reviewed Dec 5, 2025
View reviewed changes
vshankar
vshankar requested changes Dec 9, 2025
View reviewed changes
Copy link
Contributor

@vshankar vshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joscollin PTAL at comments.

@joscollin
Copy link
Member Author

joscollin commented Dec 9, 2025

@joscollin PTAL at comments.

Will revisit next week.

anthonyeleven
anthonyeleven reviewed Dec 9, 2025
View reviewed changes
@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch 2 times, most recently from 2b34951 to b099303 Compare January 7, 2026 09:37
@joscollin
Copy link
Member Author

joscollin commented Jan 7, 2026

@vshankar Addressed all review comments. Please check.

vshankar
vshankar reviewed Jan 22, 2026
View reviewed changes
vshankar
vshankar reviewed Jan 22, 2026
View reviewed changes
@vshankar
Copy link
Contributor

vshankar commented Feb 19, 2026

jenkins retest this please

@vshankar
Copy link
Contributor

vshankar commented Feb 19, 2026

This PR is under test in https://tracker.ceph.com/issues/75027.

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch from b099303 to e6bdb27 Compare March 3, 2026 00:52
@joscollin
Copy link
Member Author

joscollin commented Mar 3, 2026

Test passed:
https://pulpito.ceph.com/jcollin-2026-03-02_23:59:46-fs:mirror-wip-jcollin-testing-02032006-distro-default-trial/

joscollin added 3 commits March 3, 2026 09:10
@joscollin
cephfs_mirror: add --sync-latest-snapshot and --sync_from_snapshot op…
5fee29f 
…tions

Fixes: https://tracker.ceph.com/issues/69966
Fixes: https://tracker.ceph.com/issues/69187
Fixes: https://tracker.ceph.com/issues/69188
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin
qa: add test for --sync-latest-snapshot and --sync_from_snapshot options
04ec51f 
Fixes: https://tracker.ceph.com/issues/69966
Fixes: https://tracker.ceph.com/issues/69187
Fixes: https://tracker.ceph.com/issues/69188
Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin
doc: update --sync-latest-snapshot and --sync_from_snapshot options
4fdc7ff 
Fixes: https://tracker.ceph.com/issues/69966
Fixes: https://tracker.ceph.com/issues/69187
Fixes: https://tracker.ceph.com/issues/69188
Signed-off-by: Jos Collin <jcollin@redhat.com>
@vshankar
Copy link
Contributor

vshankar commented Mar 3, 2026

Test passed: https://pulpito.ceph.com/jcollin-2026-03-02_23:59:46-fs:mirror-wip-jcollin-testing-02032006-distro-default-trial/

That's nice but could you explain the bug that was found during fs suite testing.

@joscollin joscollin force-pushed the wip-F69187-sync-from-snapshot branch from e6bdb27 to 4fdc7ff Compare March 3, 2026 09:39
@joscollin
Copy link
Member Author

joscollin commented Mar 3, 2026

Test passed: https://pulpito.ceph.com/jcollin-2026-03-02_23:59:46-fs:mirror-wip-jcollin-testing-02032006-distro-default-trial/

That's nice but could you explain the bug that was found during fs suite testing.

sync_from_snapshot was assigned "" by mistake, which caused a full sync.

@joscollin
Copy link
Member Author

joscollin commented Mar 4, 2026

jenkins test make check

@joscollin
Copy link
Member Author

joscollin commented Mar 4, 2026

jenkins test make check arm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vshankar vshankar vshankar requested changes

@anthonyeleven anthonyeleven anthonyeleven left review comments

@dparmar18 dparmar18 dparmar18 left review comments

Requested changes must be addressed to merge this pull request.

Assignees

@kotreshhr kotreshhr

Labels

cephfs Ceph File System documentation pybind tests wip-vshankar-testing2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joscollin @vshankar @anthonyeleven @dparmar18 @kotreshhr