rgw/cksum: GetObject omits checksum headers for Range requests#61901
Merged
rgw/cksum: GetObject omits checksum headers for Range requests#61901
Conversation
mattbenjamin
approved these changes
Feb 19, 2025
Contributor
mattbenjamin
left a comment
There was a problem hiding this comment.
thanks for running this down, god be praised
Contributor
Author
|
will test against ceph/s3-tests#621 which reenables the relevant s3-tests |
if we send response headers containing full-object checksums, clients will compare them with the returned data and fail with: > botocore.exceptions.FlexibleChecksumError: Expected checksum 4AAr8A== did not match calculated checksum: WbxXZw== the only thing aws docs[1] say about Range requests refers to multipart uploads: > For completed uploads, you can get an individual part's checksum by using the GetObject or HeadObject operations and specifying a part number or byte range that aligns with a single part. Fixes: https://tracker.ceph.com/issues/69936 [1] https://docs.aws.amazon.com/AmazonS3/latest/userguide/checking-object-integrity.html#Part-level-checksums Signed-off-by: Casey Bodley <cbodley@redhat.com>
Contributor
Author
|
qa failed on new test case test_verify_remove_client_id_from_oidc, so i'll need to rerun against the rebase |
Contributor
Author
Contributor
Author
|
jenkins test make check arm64 |
Member
|
jenkins test make check arm64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if we send response headers containing full-object checksums, clients will compare them with the returned data and fail with:
the only thing aws docs say about Range requests refers to multipart uploads:
Fixes: https://tracker.ceph.com/issues/69936
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e