test/rbd_mirror: flush watch/notify callbacks in TestImageReplayer#61847
Merged
test/rbd_mirror: flush watch/notify callbacks in TestImageReplayer#61847
Conversation
TestImageReplayer establishes its own (i.e. outside of the SUT code) watch on the header of the remote image to be able to synchronize the execution of the test with certain notifications. This watch is established before the remote image is opened and is teared down until after the remote image is closed but while the image replayer is still running. The flush that is part of image close sequence thus isn't guaranteed to cover all callbacks, especially for snapshot-based mirroring where UnlinkPeerRequest spawned from Replayer::unlink_peer() generates a notification on the remote image for each completed unlink. Since TestImageReplayer further immediately deletes C_WatchCtx, pretty much any test can segfault when C_WatchCtx::handle_notify() is invoked by TestWatchNotify infrastructure. Because it's a virtual method, the segfault often involves a completely bogus instruction pointer: fn_anonymous[3176255]: segfault at b ip 000000000000000b sp 00007fffbceba7a8 error 14 in unittest_rbd_mirror[555555554000+96a000] Code: Bad RIP value. Fixes: https://tracker.ceph.com/issues/63798 Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
VinayBhaskar-V
approved these changes
Feb 17, 2025
Contributor
Author
|
jenkins test api |
1 similar comment
Contributor
Author
|
jenkins test api |
This was referenced Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestImageReplayer establishes its own (i.e. outside of the SUT code) watch on the header of the remote image to be able to synchronize the execution of the test with certain notifications. This watch is established before the remote image is opened and is teared down until after the remote image is closed but while the image replayer is still running. The flush that is part of image close sequence thus isn't guaranteed to cover all callbacks, especially for snapshot-based mirroring where UnlinkPeerRequest spawned from Replayer::unlink_peer() generates a notification on the remote image for each completed unlink. Since TestImageReplayer further immediately deletes C_WatchCtx, pretty much any test can segfault when C_WatchCtx::handle_notify() is invoked by TestWatchNotify infrastructure. Because it's a virtual method, the segfault often involves a completely bogus instruction pointer:
fn_anonymous[3176255]: segfault at b ip 000000000000000b sp 00007fffbceba7a8 error 14 in unittest_rbd_mirror[555555554000+96a000]
Code: Bad RIP value.
Fixes: https://tracker.ceph.com/issues/63798
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e