Skip to content

mgr/dashboard: tox command to generate the nvmeof proto files#61846

Merged
nizamial09 merged 1 commit intoceph:mainfrom
rhcs-dashboard:tox-generate-proto
Feb 26, 2025
Merged

mgr/dashboard: tox command to generate the nvmeof proto files#61846
nizamial09 merged 1 commit intoceph:mainfrom
rhcs-dashboard:tox-generate-proto

Conversation

@nizamial09
Copy link
Copy Markdown
Member

@nizamial09 nizamial09 commented Feb 17, 2025

tox -e gen-nvmeof-proto to generate the tox files

Fixes: https://tracker.ceph.com/issues/69995

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@nizamial09 nizamial09 requested a review from a team as a code owner February 17, 2025 11:32
@nizamial09 nizamial09 requested review from Pegonzal and cloudbehl and removed request for a team February 17, 2025 11:32
@nizamial09
mgr/dashboard: tox command to generate the nvmeof proto files
75a74f2 
`tox -e gen-nvmeof-proto` to generate the tox files

Fixes: https://tracker.ceph.com/issues/69995
Signed-off-by: Nizamudeen A <nia@redhat.com>
epuertat
epuertat reviewed Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@epuertat epuertat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the pip install grpcio-tools from the CMakelists, and adapt that part too to invoke this.

@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Feb 19, 2025

I'd remove the pip install grpcio-tools from the CMakelists, and adapt that part too to invoke this.

do you mean invoke the tox command inside the CMakelists? Since I am not really familiar with the CMakelists and its functions, if I were to do that is it as simple as the below where the add_tox_test invokes the tox and generates the file there? or this is going to be a custom one?

if(WITH_TESTS)
    include(AddCephTest)
    add_tox_test(mgr-dashboard-py3 TOX_ENVS py3)
    add_tox_test(mgr-dashboard-lint TOX_ENVS lint)
    add_tox_test(mgr-dashboard-check TOX_ENVS check)
    add_tox_test(mgr-dashboard-openapi TOX_ENVS openapi-check)
  endif()

@epuertat
Copy link
Copy Markdown
Member

epuertat commented Feb 19, 2025

I'd remove the pip install grpcio-tools from the CMakelists, and adapt that part too to invoke this.

do you mean invoke the tox command inside the CMakelists? Since I am not really familiar with the CMakelists and its functions, if I were to do that is it as simple as the below where the add_tox_test invokes the tox and generates the file there? or this is going to be a custom one?

if(WITH_TESTS)
    include(AddCephTest)
    add_tox_test(mgr-dashboard-py3 TOX_ENVS py3)
    add_tox_test(mgr-dashboard-lint TOX_ENVS lint)
    add_tox_test(mgr-dashboard-check TOX_ENVS check)
    add_tox_test(mgr-dashboard-openapi TOX_ENVS openapi-check)
  endif()

@pecastro's PR added that to the CMakelists.txt. We only have to fix that (and pull the back-end tests out of the WITH_MGR_DASHBOARD_FRONTEND section).

@pecastro pecastro mentioned this pull request Feb 23, 2025
Closed
14 tasks
@nizamial09
Copy link
Copy Markdown
Member Author

nizamial09 commented Feb 24, 2025

@epuertat I see that @pecastro is working on your suggestions it in his own PR, maybe we can try to do it there?

@nizamial09 nizamial09 requested a review from epuertat February 24, 2025 08:56
@nizamial09 nizamial09 merged commit 9907e16 into ceph:main Feb 26, 2025
11 of 13 checks passed
@nizamial09 nizamial09 deleted the tox-generate-proto branch February 26, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afreen23 afreen23 afreen23 approved these changes

@epuertat epuertat epuertat approved these changes

@cloudbehl cloudbehl Awaiting requested review from cloudbehl cloudbehl is a code owner automatically assigned from ceph/dashboard

@Pegonzal Pegonzal Awaiting requested review from Pegonzal Pegonzal is a code owner automatically assigned from ceph/dashboard

Assignees

No one assigned

Labels

dashboard pybind

Projects

Ceph-Dashboard
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nizamial09 @epuertat @afreen23