os/bluestore: fix do_write_v2 extentmap compress issue#61762
Merged
liu-chunmei merged 1 commit intoceph:mainfrom Feb 18, 2025
Merged
os/bluestore: fix do_write_v2 extentmap compress issue#61762liu-chunmei merged 1 commit intoceph:mainfrom
liu-chunmei merged 1 commit intoceph:mainfrom
Conversation
do_write_v2 insert extentmap by aligned offset which is adjusted in writer.do_write, if use original offset will cause extentmap can't do compress. Signed-off-by: chunmei liu <chunmei.liu@ibm.com>
Contributor
Author
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
aclamk
reviewed
Feb 18, 2025
| @@ -17521,9 +17521,6 @@ int BlueStore::_do_write_v2( | |||
| o->extent_map.fault_range(db, offset, length); | |||
Contributor
There was a problem hiding this comment.
I think the PR fix is ok, but not what troubles me is that we do some "around-searching" for blobs and extents nearby in _maybe_reuse_blob etc.
But we do fault_range on range offset-length.
I guess we need to make sure that one of conditions hold:
a) we never produce mapping that goes outside the range offset-length
or
b) we expand fault_range so much that we will not look outside
I think b) is better as there was hard limit of lookaround = min_alloc_size.
aclamk
approved these changes
Feb 18, 2025
Contributor
aclamk
left a comment
There was a problem hiding this comment.
Approved.
Comments are likely a material for another PR.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_write_v2 insert extentmap by aligned offset which is adjusted in writer.do_write, if use original offset will cause extentmap can't do compress.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e