Testing for ErasureCodePluginJerasure.cc:

ceph osd erasure-code-profile set TESTPROFILE plugin=jerasure technique= k= m=
Succeeds with no error

Also tested the ceph-helpers.sh function with a erasure-code-profile set technique= call and observed the following:

erasure_code_plugin_exists isa
Returns 0 and prints 'Error ENOENT: technique= is not a valid coding technique. Choose one of the following: reed_sol_van,cauchy'

erasure_code_plugin_exists jerasure
Returns 0, no error printed due to ErasureCodePluginJerasure.cc change

erasure_code_plugin_exists jbob
Returns 1

Changes look good, but this unit test is failing because we have made the code match the documentation and default to reed_sol_van!

src/test/erasure-code/TestErasureCodePluginJerasure.cc

TEST(ErasureCodePlugin, factory)
{
  ErasureCodePluginRegistry &instance = ErasureCodePluginRegistry::instance();
  ErasureCodeProfile profile;
  {
    ErasureCodeInterfaceRef erasure_code;
    EXPECT_FALSE(erasure_code);
    EXPECT_EQ(-ENOENT, instance.factory("jerasure",
                                        g_conf().get_val<std::string>("erasure_code_dir"),
                                        profile,
                                        &erasure_code, &cerr));
    EXPECT_FALSE(erasure_code);
  }

We should fix the test so it provides an invalid technique for this first test adding something like profile["technique"] = "doesnotexist"; before calling factory. Should also probably move ErasureCodeProfile profile; inside the {

Hopefully will see green now.

[root@ceph build]# bin/unittest_erasure_code_plugin_jerasure
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from ErasureCodePlugin
[ RUN ] ErasureCodePlugin.factory
load: jerasure technique=doesnotexist is not a valid coding technique. Choose one of the following: reed_sol_van, reed_sol_r6_op, cauchy_orig, cauchy_good, liberation, blaum_roth, liber8tion[ OK ] ErasureCodePlugin.factory (6 ms)
[----------] 1 test from ErasureCodePlugin (6 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (6 ms total)
[ PASSED ] 1 test.

jenkins retest this please

jenkins test windows

@ljflores all the checks have passed on this one but I saw you've added the needs-qa label, shall I hold off on merging it?

Hey @connorfawcett yeah, the "needs-qa" tag means that it is in the queue to go into integration testing. We'll add it in the next batch.

I added you to the Slack channel where integration testing is coordinated. We often do integration testing in batches to conserve resources. However, you are also welcome to test your PR yourself. The main thing is that the PR should pass integration testing before being merged, whether it goes through the batched pipeline or your own.

Here's the doc page that summarizes how to schedule integration tests if you're curious: https://docs.ceph.com/en/latest/dev/developer_guide/testing_integration_tests/tests-integration-testing-teuthology-intro/

And here's a page describing the "batched" process and how we review/approve the results prior to merging: https://tracker.ceph.com/projects/rados/wiki/QA_ANALYSIS

rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues70009