Tentacle kickoff! by batrick · Pull Request #61321 · ceph/ceph

batrick · 2025-01-10T16:31:58Z

Dependencies:

Tentacle kickoff! ceph-build#2315

Contribution Guidelines

To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

Tracker (select at least one)
- References tracker ticket
- Very recent bug; references commit where it was introduced
- New feature (ticket optional)
- Doc update (no ticket needed)
- Code cleanup (no ticket needed)
Component impact
- Affects Dashboard, opened tracker ticket
- Affects Orchestrator, opened tracker ticket
- No impact that needs to be tracked
Documentation (select at least one)
- Updates relevant documentation
- No doc update is appropriate
Tests (select at least one)
- Includes unit test(s)
- Includes integration test(s)
- Includes bug reproducer
- No tests

Show available Jenkins commands

jenkins retest this please
jenkins test classic perf
jenkins test crimson perf
jenkins test signed
jenkins test make check
jenkins test make check arm64
jenkins test submodules
jenkins test dashboard
jenkins test dashboard cephadm
jenkins test api
jenkins test docs
jenkins render docs
jenkins test ceph-volume all
jenkins test ceph-volume tox
jenkins test windows
jenkins test rook e2e

doc/dev/release-checklists.rst

src/mon/OSDMonitor.cc

rzarzynski

Review in progress.

doc/dev/release-checklists.rst

rzarzynski · 2025-01-16T21:38:04Z

doc/dev/release-checklists.rst

- [ ] update src/ceph-volume/ceph_volume/__init__.py (`__release__`)
- [ ] update src/cephadm/cephadmlib/constants.py (`DEFAULT_IMAGE_RELEASE` to X)
+- [x] update src/ceph-volume/ceph_volume/__init__.py (`__release__`)
+- [x] update src/cephadm/cephadmlib/constants.py (`DEFAULT_IMAGE_RELEASE` and `LATEST_STABLE_RELEASE` to X)


rzarzynski · 2025-01-16T21:45:24Z

src/include/ceph_features.h

 DEFINE_CEPH_FEATURE(49, 2, SERVER_SQUID);
 DEFINE_CEPH_FEATURE_RETIRED(50, 1, MON_METADATA, MIMIC, OCTOPUS)
-// available
+DEFINE_CEPH_FEATURE(50, 2, SERVER_TENTACLE);


Seems fine.

rzarzynski

ACK from core.

rzarzynski · 2025-02-06T16:31:29Z

doc/dev/release-checklists.rst

 - [ ] cherry-pick 8cf9ad62949516666ad0f2c0bb7726ef68e4d666 ("doc: add releases links to toc"). There will be trivial conflicts.
 - [ ] add redirect for new major release at `RTD <https://readthedocs.org/dashboard/ceph/redirects/>`_.
- [ ] add release name to redmine (using https://tracker.ceph.com/custom_fields/16/edit)
+- [x] add release name to redmine (using https://tracker.ceph.com/custom_fields/16/edit)


rzarzynski · 2025-02-06T16:41:56Z

doc/dev/release-checklists.rst

+- [x] create qa/workunits/test_telemetry_(X-1)_x.sh
+- [x] create qa/suites/upgrade/(X-1)-x
+- [x] remove qa/suites/upgrade/(X-3)-x-*
+- [x] update qa/fs/upgrade/ to remove (X-3) and add (X-1); check with fs team to confirm / help


CC: @vshankar & @gregsfortytwo.

jmundack · 2025-02-06T17:27:03Z

from what i can tell, there seems to be 3 sets of changes here

tentacle related things
remove quicy
add some things for squid

can/shall we separate out these into separate PR's?

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

See ceph/ceph-build#2315 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

I don't see a reason to restrict the update to X-1. Just add up to X. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

It's no longer necessary per: ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

I don't see a good reason to set this to X-2 for a new cluster so I've adjusted it to X and updated this missing item in the doc. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

batrick · 2025-02-17T18:41:46Z

This PR is under test in https://tracker.ceph.com/issues/70000.

rzarzynski · 2025-02-20T22:00:32Z

jenkins test api

batrick · 2025-02-21T03:11:01Z

@rzarzynski I think this is close to being ready. the upgrade suite continues to be very broken 😠. Mostly failures like:

https://pulpito.ceph.com/pdonnell-2025-02-20_01:59:34-fs-wip-pdonnell-testing-20250218.200348-debug-distro-default-smithi/8141856/

but at least some of those are from cephadm upgrades and should have set tentacle AFAICT. So some work to figure that out.

I recommend scheduling anything additional you like with this branch/ticket:

https://tracker.ceph.com/issues/70000

cc @adamemerson @vshankar @idryomov

batrick · 2025-02-21T03:12:33Z

I'd like to add: in the interest of avoiding rebases and "getting this out the door", we might merge soon and then incrementally clean up before branching off tentacle.

rzarzynski · 2025-02-21T14:47:54Z

@ljflores, @yuriw: let's run this through the RADOS suite using https://tracker.ceph.com/issues/70000 for tracking, if possible.

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

It's no longer necessary per: ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

batrick · 2025-02-24T18:42:37Z

cephadm upgrade issue is noted:

https://tracker.ceph.com/issues/70000#note-3

I think we can merge this.

rzarzynski · 2025-02-26T23:27:17Z

@ljflores: are you fine?

ljflores · 2025-02-27T18:16:40Z

@ljflores: are you fine?

I'll reply shortly with a rados review.

ljflores · 2025-02-27T21:13:29Z

Rados approved: https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues70000

Please note that there are three new trackers directly related to this PR, but @rzarzynski confirmed they are not blockers:

https://tracker.ceph.com/issues/70212 - cephadm/test_cephadm: ERROR: Container release squid != cephadm release tentacle
https://tracker.ceph.com/issues/70214 - rados/upgrade: Health check failed: all OSDs are running tentacle or later but require_osd_release < tentacle (OSD_UPGRADE_FINISHED)
https://tracker.ceph.com/issues/70215 - rados/thrash-old-clients: unable to install tentacle packages

batrick requested review from a team as code owners January 10, 2025 16:31

github-actions bot added build/ops ceph-volume cephadm cephfs Ceph File System common core documentation mon rbd script tests labels Jan 10, 2025

batrick mentioned this pull request Jan 10, 2025

Tentacle kickoff! ceph/ceph-build#2315

Merged

batrick force-pushed the tentacle-kickoff branch from 0d72848 to 6562bd7 Compare January 10, 2025 16:54

batrick commented Jan 10, 2025

View reviewed changes

doc/dev/release-checklists.rst Outdated Show resolved Hide resolved

batrick commented Jan 10, 2025

View reviewed changes

doc/dev/release-checklists.rst Outdated Show resolved Hide resolved

batrick commented Jan 10, 2025

View reviewed changes

doc/dev/release-checklists.rst Outdated Show resolved Hide resolved

bill-scales reviewed Jan 10, 2025

View reviewed changes

src/mon/OSDMonitor.cc Outdated Show resolved Hide resolved

batrick force-pushed the tentacle-kickoff branch from 6562bd7 to 7a63362 Compare January 10, 2025 18:01

github-actions bot added the needs-rebase label Jan 11, 2025

rzarzynski reviewed Jan 16, 2025

View reviewed changes

rzarzynski approved these changes Feb 6, 2025

View reviewed changes

batrick force-pushed the tentacle-kickoff branch from 7a63362 to 5b43d4f Compare February 6, 2025 19:19

github-actions bot removed the needs-rebase label Feb 6, 2025

ceph deleted a comment from github-actions bot Feb 6, 2025

batrick added a commit to batrick/ceph that referenced this pull request Feb 6, 2025

doc/dev/release-checklists:: mark task complete

b2b7085

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

batrick added 10 commits February 17, 2025 13:38

doc/dev/release-checklist: question telemetry tentacle test

0be5482

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

qa: update to tentacle

b5e93df

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

doc/dev/release-checklists: note redmine is done

1ecb95d

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

doc/dev/release-checklists: update ceph-build for tentacle

fb30a78

See ceph/ceph-build#2315 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

doc/dev/release-checklist: add nightlies task

6f6bb74

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

doc/dev/release-checklists:: mark task complete

52efefe

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/ceph-release-notes: add squid/tentacle

4adc8b5

I don't see a reason to restrict the update to X-1. Just add up to X. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

doc/dev/release-checklists: remove ceph-container task

a814863

It's no longer necessary per: ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

tools/monmaptool: bump new cluster version to X

7e4fe06

I don't see a good reason to set this to X-2 for a new cluster so I've adjusted it to X and updated this missing item in the doc. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

qa: update require-osd-release to tentacle

012ab7f

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

batrick force-pushed the tentacle-kickoff branch from 4b5f5d8 to 012ab7f Compare February 17, 2025 18:39

github-actions bot added the telemetry label Feb 17, 2025

rzarzynski pushed a commit to rzarzynski/ceph that referenced this pull request Feb 21, 2025

doc/dev/release-checklists:: mark task complete

f912ae1

ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

rzarzynski pushed a commit to rzarzynski/ceph that referenced this pull request Feb 21, 2025

doc/dev/release-checklists: remove ceph-container task

88bcfef

It's no longer necessary per: ceph#61321 (comment) Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

rzarzynski added the needs-qa label Feb 21, 2025

rzarzynski mentioned this pull request Feb 21, 2025

common: dezeroize bufferlists across the stack #60104

Closed

14 tasks

SrinivasaBharath added wip-bharath4-testing and removed wip-bharath4-testing labels Mar 2, 2025

batrick merged commit 58ab881 into ceph:main Mar 3, 2025
12 of 13 checks passed

batrick deleted the tentacle-kickoff branch March 3, 2025 13:35

batrick mentioned this pull request Dec 6, 2025

Umbrella checklist kickoff! #66524

Open

14 tasks

Conversation

batrick commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Contribution Guidelines

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rzarzynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rzarzynski Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

rzarzynski Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

rzarzynski left a comment

Choose a reason for hiding this comment

Uh oh!

rzarzynski Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

rzarzynski Feb 6, 2025

Choose a reason for hiding this comment

Uh oh!

jmundack commented Feb 6, 2025

Uh oh!

batrick commented Feb 17, 2025

Uh oh!

rzarzynski commented Feb 20, 2025

Uh oh!

batrick commented Feb 21, 2025

Uh oh!

batrick commented Feb 21, 2025

Uh oh!

rzarzynski commented Feb 21, 2025

Uh oh!

batrick commented Feb 24, 2025

Uh oh!

rzarzynski commented Feb 26, 2025

Uh oh!

ljflores commented Feb 27, 2025

Uh oh!

ljflores commented Feb 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

batrick commented Jan 10, 2025 •

edited

Loading