squid: mds,client: correct last_issue struct fields and consistently send last_issue in cap messages#61300
Merged
hkadam134 merged 7 commits intoceph:squidfrom Aug 21, 2025
Merged
Conversation
A const getter already exists. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit a72b31e)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 7766d3c)
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 6d8a734)
Originally, the last_sent sequence from the MDS was sent by the client during bulk cap release but it was shortly after changed to the last_issue which is the sequence number that the cap was originally "issued" by the MDS rank (which may be updated after import of caps). Fixes: 6208f57 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit 655cddb)
Right now only the clients tell the MDS what they believe the issue_seq to be. The clients are expected to figure out issue_seq updates at Fixes: https://tracker.ceph.com/issues/68515 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com> (cherry picked from commit cb4ff28)
Member
Author
|
jenkins test api |
Member
Author
Credit to Ilya Dryomov for spotting this. [1] ceph#60283 (comment) Fixes: 1da6ef2 Fixes: https://tracker.ceph.com/issues/68973 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit a07c5ef)
Member
Author
|
jenkins test api |
Contributor
|
The PR is under test in https://tracker.ceph.com/issues/72364 |
Contributor
|
QA Runs are completed and failure analysed and updated the wiki - |
Contributor
|
@vshankar -- Patrick reviewed the QA Runs - https://tracker.ceph.com/issues/72364#note-6 |
vshankar
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker:
backport of #60283
parent tracker: https://tracker.ceph.com/issues/68515
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh