squid: log: concatenate thread names and print once per thread#61287
Merged
batrick merged 4 commits intoceph:squidfrom Apr 30, 2025
Merged
squid: log: concatenate thread names and print once per thread#61287batrick merged 4 commits intoceph:squidfrom
batrick merged 4 commits intoceph:squidfrom
Conversation
Fixes: 0be8d01 Fixes: https://tracker.ceph.com/issues/68691 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 1f40d0c)
This provides common ceph entrypoints for the pthread_[gs]name functions which will also cache a thread_local copy. This also removes the pthread_t parameter which precipitated the bug i50743. Obviously, the overall goal here is to avoid system calls. See-also: https://tracker.ceph.com/issues/50743 Fixes: 0be8d01 Fixes: https://tracker.ceph.com/issues/68691 Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit 7de5af5) Conflicts: src/ceph_nvmeof_monitor_client.cc: not present src/mds/Beacon.cc: trivial
In general, a pthread implementation reuses thread ids routinely so the circular_buffer is there to help us see what the thread name was historically (capped at 4 entries). However, to guard against this map from growing without bound, discard entries that are more than a day old. This would happen if a thread logged an Entry and has since disappeared for more than a day. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit bfe489e)
To be consistent and sensical. Signed-off-by: Patrick Donnelly <pdonnell@ibm.com> (cherry picked from commit a2a989a)
Member
Author
|
jenkins test make check |
Contributor
|
PR is under test - https://tracker.ceph.com/issues/70262 |
Contributor
|
No New Issues found, PR is Tested and needs approval to merge. |
Contributor
|
This PR requires Core and RGW Test coverage: Triggered runs here : https://tracker.ceph.com/issues/70262#note-8 |
ljflores
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/68926
backport of #60464
parent tracker: https://tracker.ceph.com/issues/68691
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh