crimson/common/tri_mutex: improve logging#61253
Merged
Conversation
amathuria
approved these changes
Jan 7, 2025
athanatos
reviewed
Jan 7, 2025
cyx1231st
approved these changes
Jan 8, 2025
Member
cyx1231st
left a comment
There was a problem hiding this comment.
LGTM except an unresolved comment.
Creating an ObjectContext instance will also result in creating unnecessary members such as ObjectContext::tri_mutex. While it should not cause any issues, it makes debugging tri_mutex much harder as each object will result in an extra (unused) lock which is destructed in the end of every run_executer execution (due to the required `rollback_on_error.cancel()` call). Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
This partially reverts 822c7d9. As passing hobject::to_str instead of hoid.oid.name will also include snap info. Signed-off-by: Matan Breizman <mbreizma@redhat.com>
e1be2d3 to
0e027d5
Compare
Contributor
Author
|
jenkins test windows |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with debugging issues as: https://tracker.ceph.com/issues/69406.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e