osd/PeeringState: rename "cancel_backfill" to "suspend_backfill"#61232
Merged
osd/PeeringState: rename "cancel_backfill" to "suspend_backfill"#61232
Conversation
14 tasks
Matan-B
reviewed
Jan 6, 2025
Contributor
Matan-B
left a comment
There was a problem hiding this comment.
This requires a commit message, what do you think about?
PerringState events the are leading to `cancel_backfill()` are:
* DeferBackfill - Called if local recovery reservation is revoked before it completes (See AsyncResever::request_reservation on_preempt)
* UnfoundBackfill
* RemoteReservationRevokedTooFull
* RemoteReservationRevoked
In each event, we merely suspend the the backfill.
The primary will *continue* to keep trying to start this backfill as long as the up set for the current interval includes the osds that needs to be backfilled.
Eventually, the backfill will either succeed and complete or will be made irrelevant due to an interval change (and essentially truly "cancelled")
nit:
In PrimaryLogPG::do_scan we should update the logs to mention suspend instead of cancel:
dout(1) << __func__ << ": Canceling backfill: Full." << dendl;
...
// we canceled backfill for a while due to a too full, and this
// is an extra response from a non-too-full peer
dout(20) << __func__ << " canceled backfill (too full?)" << dendl;
| } | ||
|
|
||
| void PG::on_backfill_canceled() | ||
| void PG::on_backfill_suspended() |
Contributor
There was a problem hiding this comment.
Perhaps we should add a comment as to why we are clearing waiting_on_backfill on suspend?
// Scan replies asked before suspending this backfill should be ignored.
// See PrimaryLogPG::do_scan - case MOSDPGScan::OP_SCAN_DIGEST.
// `waiting_on_backfill` will be re-refilled after the suspended backfill is resumed/restarted.
athanatos
approved these changes
Jan 7, 2025
0378adf to
807c3f9
Compare
PerringState events the are leading to `cancel_backfill()` are: * DeferBackfill - Called if local recovery reservation is revoked before it completes (See AsyncResever::request_reservation on_preempt) * UnfoundBackfill * RemoteReservationRevokedTooFull * RemoteReservationRevoked In each event, we merely suspend the the backfill. The primary will *continue* to keep trying to start this backfill as long as the up set for the current interval includes the osds that needs to be backfilled. Eventually, the backfill will either succeed and complete or will be made irrelevant due to an interval change (and essentially truly "cancelled") Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
807c3f9 to
29c4337
Compare
Contributor
|
QA run approved (see https://tracker.ceph.com/projects/rados/wiki/MAIN#httpstrackercephcomissues69648) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xuehan Xu xuxuehan@qianxin.com
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windowsjenkins test rook e2e