Skip to content

crimson/common/shared_lru: invalidate Deleter's cache#61213

Merged
Matan-B merged 2 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-shared-lru-dtor
Jan 7, 2025
Merged

crimson/common/shared_lru: invalidate Deleter's cache#61213
Matan-B merged 2 commits intoceph:mainfrom
Matan-B:wip-matanb-crimson-shared-lru-dtor

Conversation

@Matan-B
Copy link
Contributor

@Matan-B Matan-B commented Jan 2, 2025

Once we destruct SharedLRU, SharedLRU::weak_refs map is destroyed.
As a weak refernce might outlive the SharedLRU itself, when destroying
the object via the custom Deleter, we try to access the already
destroyed SharedLRU instance's weak ref map.

Instead, invalidate the custom Deleter (Deleter::cache), when
destructing the SharedLRU.

Fixes: https://tracker.ceph.com/issues/66478

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

Once we destruct SharedLRU, SharedLRU::weak_refs map is destroyed.
As a weak refernce might outlive the SharedLRU itself, when destroying
the object via the custom Deleter, we try to access the already
destroyed SharedLRU instance's weak ref map.

Instead, invalidate the custom Deleter (Deleter::cache), when
destructing the SharedLRU.

Fixes: https://tracker.ceph.com/issues/66478

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B requested a review from cyx1231st January 2, 2025 15:37
to not be confused with SharedLRU::cache

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
@Matan-B Matan-B force-pushed the wip-matanb-crimson-shared-lru-dtor branch from 7b79eb1 to 7989e98 Compare January 2, 2025 16:15
@Matan-B Matan-B marked this pull request as ready for review January 2, 2025 16:15
@Matan-B Matan-B requested a review from a team as a code owner January 2, 2025 16:15
@Matan-B Matan-B requested a review from athanatos January 2, 2025 16:18
@Matan-B
Copy link
Contributor Author

Matan-B commented Jan 7, 2025

https://pulpito.ceph.com/matan-2025-01-06_10:21:37-crimson-rados-wip-matanb-crimson-testing-january-5-distro-crimson-smithi/

Failures:
510, 577: NeoRadosPools - https://tracker.ceph.com/issues/69405
634: bluestore hangs (due to can't lock) - https://tracker.ceph.com/issues/69406
New:
587: https://tracker.ceph.com/issues/69439 - thrash/short_pg_log: trim_to <= peering_state.get_pg_committed_to()
537: https://tracker.ceph.com/issues/69436 - ceph_assert(version == old_value.version)
628: https://tracker.ceph.com/issues/69438 - thrash/short_pg_log: bluestore op got ENOENT - setattr
Dead:
rest dead jobs seastore trash (will be cleaned out from the suite)

@Matan-B Matan-B merged commit 87648ed into ceph:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Merged (Pre Tentacle Freeze)

Development

Successfully merging this pull request may close these issues.

3 participants